Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E2E test for Steel EIP4788 commitments #203

Closed
Wollac opened this issue Aug 24, 2024 · 1 comment · Fixed by #228
Closed

Add E2E test for Steel EIP4788 commitments #203

Wollac opened this issue Aug 24, 2024 · 1 comment · Fixed by #228
Assignees
Labels

Comments

@Wollac
Copy link
Contributor

Wollac commented Aug 24, 2024

Currently, there is no test for the Steel commitment introduced in #180. There are some unit tests for the individual (mocked) components, but an end-to-end test that includes the Steel proof generation and on-chain verification is missing, so we have no automated checks if this breaks.
There should be a CI test that does the following

  • Spin up an Ethereum PoS devnet (e.g. using OffchainLabs/eth-pos-devnet)
  • Deploys the erc20-counter contracts.
  • Create a Steel proof using the consensus node in the devnet.
  • Validate the successful on-chain verification.

(Everything would be very similar to erc20-counter/test-local-deployment.sh, only on the local devent instead of anvil.

Copy link

linear bot commented Aug 24, 2024

@Wollac Wollac self-assigned this Sep 10, 2024
@nategraf nategraf added the steel label Sep 10, 2024 — with Linear
@Wollac Wollac closed this as completed in c8bba7d Sep 11, 2024
Wollac added a commit that referenced this issue Oct 7, 2024
This PR turns the `erc20-counter` example into an end-to-end test. It
uses a local Ethereum devnet including an execution and consensus client
based on the
[ethpandaops/ethereum-package](https://github.com/ethpandaops/ethereum-package)
Kurtosis package.
In the CI, all contracts are deployed on the devnet before a full proof
is generated and validated with a block and a beacon commitment.

closes #203
closes WEB3-90

---------

Co-authored-by: Victor Graf <victor@risczero.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants