WEB3-68: feat: Add EIP4788 commitments #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wollac
force-pushed
the
feat/beacon-input
branch
from
c8d2d77
to
9b14c9b
Compare
|
Marked draft, as it is dependent on switching from Ethers to Alloy. Once that PR is in, this PR will be ready to go. |
Wollac
force-pushed
the
feat/beacon-input
branch
from
e23f77b
to
47b4829
Compare
github-actions
bot
changed the title
nategraf
reviewed
Aug 8, 2024
Wollac
changed the title
This PR adds a version to the commitments generated by Steel. This allows us to distinguish between regular block commits (verified using the `blockhash` opcode) and beacon commits (verified using the EIP-4788 beacon roots contract) based on the commitment data alone. It uses the top 2 bytes of the commitment's `blockID` field as the version. This leaves a `uint240` for the actual identifier, which is more than sufficient for the block number or block timestamp.
Wollac
commented
Aug 16, 2024
nategraf
approved these changes
Aug 16, 2024
Wollac
commented
Aug 22, 2024
nategraf
added a commit
that referenced
this pull request
Aug 23, 2024
Adds the option to commit to a Beacon (Consensus) block instead of an Execution block. --------- Co-authored-by: capossele <angelocapossele@gmail.com> Co-authored-by: Victor Graf <victor@risczero.com>
Wollac
added a commit
that referenced
this pull request
Oct 7, 2024
Adds the option to commit to a Beacon (Consensus) block instead of an Execution block. --------- Co-authored-by: capossele <angelocapossele@gmail.com> Co-authored-by: Victor Graf <victor@risczero.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option to commit to a Beacon (Consensus) block instead of an Execution block.