Add emergency stop and verifier router contracts for version management #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rifier-version-mgmt
|
@capossele, this is ready for review when you have a chance |
pdg744
reviewed
May 8, 2024
pdg744
reviewed
May 8, 2024
Co-authored-by: Paul <paul.gafni@gmail.com>
nategraf
added a commit
to risc0/risc0
that referenced
this pull request
May 8, 2024
…o CONTROL_ROOT (#1794) Following up on #1764, this PR adds the selector value to the encoded seal in `TestReceipt.sol` and renames `CONTROL_ID` to `CONTROL_ROOT`, which is more accurate to what is actually implemented. Related to risc0/risc0-ethereum#80, where the changes have been made to use the newly bootstrapped values.
nategraf
changed the title
nategraf
added a commit
that referenced
this pull request
May 11, 2024
This PR adds documentation describing the design of the verifier contract version management solution implemented in #80. It is intended to provide detailed information to help security-minded application developers make an informed decision about how to use the verifier contracts. --------- Co-authored-by: Paul <paul.gafni@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we get ready to deploy RISC Zero verifiers to Ethewreum mainnet, we need a system to manage versions of the verifier contract and proof system. In particular, we need a way to respond to critical bugs, and we need a way to make upgraded versions of the proof system available to developers. Both mechanisms need to be opt-in so that applications can choose the solution that works best for their security model.
This PR implements a basic version management system, based around two new contracts:
RiscZeroVerifierEmergencyStopis a wrapper around a verifier contract that allows for the verifier to be shutdown if a critical bug is discovered.RiscZeroVerifierRouteris a wrapper around a list of verifiers that allows new verifiers to be added to support proof system upgrades.These are intended to be used together with an authorized multisig, and a
TimelockControlleron addition of new verifiers.This PR is currently marked as draft, as the verifier identifiers are not yet fully implemented in the
risc0codebase.Also addresses #30 as part of a refactor to the
IRiscZeroVerifierinterface.Related to risc0/risc0#1794, from which the verifier parameters have been bootstrapped.