CAPSTONE-NG (AFTER 5.0) #3564

XVilka · 2023-06-08T11:35:45Z

Your checklist for this pull request

I've read the guidelines for contributing to this repository
I made sure to follow the project's coding style
I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
I've added tests that prove my fix is effective or that my feature works (if possible)
I've updated the rizin book with the relevant information (if needed)

Detailed description

Once auto-sync for ARM, AARCH64, PPC is merged, corresponding tests should be fixed and this PR merged into dev

Test plan

CI is green, no additional BROKEN marks compared to the current dev

Closing issues

Depends on:

this are the changes from volumit (https://github.com/volumit/qemu/commits/master) compacted into one patch. Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>

XVilka · 2023-06-30T09:49:26Z

As capstone-engine/capstone@f8f50f0 was merged, this branch should be updated and removed using % from tests for the Tricore registers

XVilka · 2023-07-05T02:22:50Z

There is one problem that fails our ASAN build: capstone-engine/capstone#1978

imbillow · 2023-07-05T02:33:07Z

There is one problem that fails our ASAN build: capstone-engine/capstone#1978

We can use werror=false for capstone subproject

Rot127 · 2023-07-05T09:41:58Z

Hope this helps: capstone-engine/capstone#2075

XVilka · 2023-07-06T04:47:44Z

Please rebase and update to the latest capstone commit, before ARM auto-sync PR is merged (I hope it will happen now)

XVilka · 2023-07-06T06:38:36Z

Nice! Looks like now it produces much better results on SPARC after that fix:

[XX] db/analysis/sparc Analyze bb with branch delay instruction head
RZ_NOPLUGINS=1 /private/var/folders/bc/yvvw2g2s4jlg9r8x7tf61xv800009d/T/woodpecker-local-1287038090/rizinorg/rizin/prefix/bin/rizin -escr.utf8=0 -escr.color=0 -escr.interactive=0 -eflirt.sigdb.load.system=false -eflirt.sigdb.load.home=false -N -Qc 's 0x0001bc04
af
afb
' bins/elf/elf-solaris-sparc-ls
-- stdout
--- expected
+++ actual
@@ -8,6 +8,6 @@
 0x0001bc98 0x0001bca8 00:0000 16 j 0x0001bcf8 f 0x0001bca8
 0x0001bca8 0x0001bcbc 00:0000 20 j 0x0001bcf8 f 0x0001bcbc
 0x0001bcbc 0x0001bcc4 00:0000 8 j 0x0001bc34 f 0x0001bcc4
-0x0001bcc4 0x0001bcec 00:0000 40 j 0x0001bc70 f 0x0001bcec
+0x0001bcc4 0x0001bcec 00:0000 40 f 0x0001bcec
 0x0001bcec 0x0001bcf8 00:0000 12 j 0x0001bc70 f 0x0001bcf8
 0x0001bcf8 0x0001bd00 00:0000 8

[XX] db/analysis/sparc analysis.fcnprefix sparc
RZ_NOPLUGINS=1 /private/var/folders/bc/yvvw2g2s4jlg9r8x7tf61xv800009d/T/woodpecker-local-1287038090/rizinorg/rizin/prefix/bin/rizin -escr.utf8=0 -escr.color=0 -escr.interactive=0 -eflirt.sigdb.load.system=false -eflirt.sigdb.load.home=false -N -Qc 's 0x00018c08
e analysis.fcnprefix=root
af
afl
' bins/elf/elf-solaris-sparc-ls
-- stdout
--- expected
+++ actual
@@ -1,1 +1,92 @@
-0x00018c08  357 8388 -> 7340 main
+0x00018c08  344 8388 -> 7276 main
+0x0001b334    7 136          sym.set_program_name
+0x0003fb78    1 12           sym.imp.setlocale
+0x0003f98c    2 60           sym.imp.atexit
+0x0003fb60    1 12           sym.imp.abort
+0x00022a74    2 24           sym.set_quoting_style
+0x0003fb84    1 12           sym.imp.getenv
+0x0001b59c   14 248          sym.argmatch
+0x00021a50   26 416  -> 396  sym.human_options
+0x0003fb90    1 12           sym.imp.ioctl
+0x00025948   53 796          sym.xstrtoul
+0x0001f7c4    1 44           sym.rpl_getopt_long
+0x0001f720    1 116          sym._getopt_internal
+0x0001eb64  181 3004         sym._getopt_internal_r
+0x00018954    4 696          sym.usage
+0x0003fb6c    1 12           sym.imp.fprintf
+0x0003f998    1 12           sym.imp.exit
+0x0003f9e0    1 12           sym.imp.printf
+0x0003fb00    1 12           sym.imp.fwrite
+0x0003fa40    1 12           sym.imp..udiv
+0x00022a24    2 56           sym.clone_quoting_options
+0x00025720    1 32           sym.xmemdup
+0x00022a5c    2 24           sym.get_quoting_style
+0x00022a8c    2 80           sym.set_char_quoting
+0x0003fa4c    1 12           sym.imp..umul
+0x000255f0    3 56           sym.xmalloc
+0x0003fc20    1 12           sym.imp.malloc
+0x0001b558    1 44           sym.xalloc_die
+0x0001bb8c    4 120          sym.error
+0x0001386c    5 180          sym.clear_files
+0x0003f9f8    1 12           sym.imp.free
+0x00015f6c  129 2740 -> 2480 sym.gobble_file
+0x00013774    1 16           sym.dev_ino_free
+0x00013784    1 32           sym.free_pending_ent
+0x0003fb9c    1 12           sym.imp.opendir
+0x0001ba88    1 8            sym.dirfd
+0x0003fba8    1 12           sym.imp.fstat64
+0x0003fbb4    1 12           sym.imp.readdir64
+0x00013d0c    6 72           sym.patterns_match
+0x0001e84c    3 552  -> 80   sym.gnu_fnmatch
+0x0003fa70    1 12           sym.imp.strlen
+0x0001caf4  198 2792 -> 2732 sym.internal_fnmatch
+0x00013cd8    1 52           sym.file_failure
+0x0003fbc0    1 12           sym.imp.closedir
+0x00015c2c   13 396  -> 368  sym.sort_files
+0x00016a20   31 748  -> 508  sym.quote_name
+0x0003fb0c    1 12           sym.imp.memcpy
+0x0003f9d4    1 12           sym.imp.fputs
+0x00016da0   31 420          sym.restore_default_color
+0x0003fb18    1 12           sym.imp.fflush
+0x0003fbcc    1 12           sym.imp.sigismember
+0x0003fb3c    1 12           sym.imp.signal
+0x0003fb30    1 12           sym.imp.raise
+0x0003fbd8    1 12           sym.imp.isatty
+0x000237dc    1 108          sym.quotearg
+0x000237a8    1 28           sym.quotearg_n
+0x00023634   15 372          sym.quotearg_n_options
+0x000237c4    1 24           sym.quotearg_n_mem
+0x00022afc    1 12           sym.quoting_options_from_style
+0x0001b7e4    3 88           sym.__xargmatch_internal
+0x0001b694    3 88           sym.argmatch_invalid
+0x0001b6ec    9 248          sym.argmatch_valid
+0x00013920    1 40           sym.add_ignore_pattern
+0x0001b528    1 48           sym.version_etc
+0x0001b3e4   16 324  -> 316  sym.version_etc_va
+0x00013d80   22 476  -> 344  sym.extract_dirs_from_files
+0x00017b7c    3 3544 -> 56   sym.print_current_files
+0x0003fa64    1 12           sym.imp.__assert_c99
+0x00022414   23 408          sym._obstack_newchunk
+0x0002396c    3 588          sym.quotearg_colon
+0x0003faa0    1 12           sym.imp.stat64
+0x0003f9ec    1 12           sym.imp.__flsbuf
+0x0001f998    1 8            sym.hash_get_n_entries
+0x000201f0   26 324          sym.hash_free
+0x0001f8d0   10 184          sym.hard_locale
+0x0003fa04    1 12           sym.imp.strncmp
+0x0003fbe4    1 12           sym.imp.strchr
+0x00022768    1 700          sym.quote
+0x000137a4    9 132          sym.is_colored
+0x0003fbf0    1 12           sym.imp.tcgetpgrp
+0x0003fbfc    1 12           sym.imp.sigemptyset
+0x0003fc08    1 12           sym.imp.sigaction
+0x0003fc14    1 12           sym.imp.sigaddset
+0x0001ff34   27 480          sym.hash_initialize
+0x00022250    8 224          sym._obstack_begin
+0x00013620   12 240          sym.dired_dump_obstack
+0x00013c38    5 104          sym.queue_directory
+0x00025758   14 436          sym.xstrtol_fatal
+0x00025740    1 24           sym.xstrdup
+0x00013948    1 64           sym.get_funky_string
+0x0003fa28    1 12           sym.imp.strcmp
+0x0003fc2c    1 12           sym.imp.acl_trivial

Needs to be carefully rechecked though

XVilka · 2023-07-07T07:40:47Z

@imbillow after the recent change of Tricore IMM representation, now also calls look wrong (no need to add # in case there is a symbol):

$ rizin -A test/bins/elf/float_ex1/float_ex1_hightec
[0x80000000]> pdf @ dbg.prout
            ;-- prout:
╭ void *dbg.prout(void *str, const char *buf, size_t n);
│           ; arg void *str @ a15
│           ; arg size_t n @ d4
│           ; arg const char *buf @ a5
│           0x80000c04      404f           mov.aa a15, a4              ; printf.c:5 ; arg5 ; void *prout(void *str, const char *buf, size_t n);
│           0x80000c06      024f           mov   d15, d4
│           0x80000c08      4054           mov.aa a4, a5               ; printf.c:6 ; arg6
│           0x80000c0a      02f5           mov   d5, d15
│           0x80000c0c      8214           mov   d4, #1
│           0x80000c0e      40f5           mov.aa a5, a15
│           0x80000c10      6d003e08       call  #dbg.fwrite           ; size_t fwrite(const void *ptr, size_t size, size_t nitems, FILE *stream)
│           0x80000c14      0bf20021       eq    d2, d2, d15
│           0x80000c18      80ff           mov.d d15, a15              ; printf.c:7
│           0x80000c1a      2bf250f2       seln  d15, d2, d2, d15
│           0x80000c1e      60f2           mov.a a2, d15
╰           0x80000c20      0090           ret
[0x80000000]>

XVilka · 2023-07-15T12:12:00Z

Superseded by #3653

XVilka assigned imbillow and Rot127 Jun 8, 2023

github-actions bot added API documentation Improvements or additions to documentation infrastructure rz-test RzAnalysis RzAsm-Disassembler labels Jun 8, 2023

XVilka assigned brightprogrammer Jun 8, 2023

XVilka added this to the 0.7.0 milestone Jun 9, 2023

XVilka mentioned this pull request Jun 16, 2023

Updated capstone project URL #3580

Merged

5 tasks

Rot127 mentioned this pull request Jun 19, 2023

[ARM] Update to Capstone v6/auto-sync #3591

Closed

5 tasks

Rot127 force-pushed the capstone-ng branch from 01ea5d6 to 5f95860 Compare June 20, 2023 11:30

XVilka mentioned this pull request Jun 21, 2023

Is this still supported/working TriDis/ditricore#2

Open

imbillow force-pushed the capstone-ng branch from 5f95860 to ac3f010 Compare June 26, 2023 02:25

XVilka referenced this pull request in bkoppelmann/qemu Jun 27, 2023

target/tricore: Add disas

a507a8c

this are the changes from volumit (https://github.com/volumit/qemu/commits/master) compacted into one patch. Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>

This comment was marked as resolved.

Sign in to view

This comment was marked as outdated.

Sign in to view

imbillow force-pushed the capstone-ng branch from ac3f010 to 8f04ca8 Compare July 4, 2023 11:29

yossizap and others added 6 commits July 6, 2023 14:18

Set the default capstone version to v5 instead of v4

4716498

Update capstone versions in the docs

b6555d6

Update capstone instruction ids

ab80329

Removing GNU tricore analysis and asm plugin

dd49f38

Adding new cs-based tricore analysis and asm plugin

74e0be2

Fixes capstone update

14b6f4a

imbillow added 2 commits July 6, 2023 14:18

Masking BROKEN tests by the cs update

6ac4cbd

Update capstone and tests

4cb6922

imbillow force-pushed the capstone-ng branch from 8f04ca8 to 4cb6922 Compare July 6, 2023 06:21

XVilka mentioned this pull request Jul 10, 2023

Support building with capstone v5.0 release #3652

Closed

XVilka closed this Jul 15, 2023

imbillow deleted the capstone-ng branch September 1, 2023 04:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CAPSTONE-NG (AFTER 5.0) #3564

CAPSTONE-NG (AFTER 5.0) #3564

XVilka commented Jun 8, 2023 •

edited

Loading

XVilka commented Jun 30, 2023

This comment was marked as resolved.

This comment was marked as outdated.

XVilka commented Jul 5, 2023

imbillow commented Jul 5, 2023 •

edited

Loading

Rot127 commented Jul 5, 2023

XVilka commented Jul 6, 2023

XVilka commented Jul 6, 2023

XVilka commented Jul 7, 2023

XVilka commented Jul 15, 2023

CAPSTONE-NG (AFTER 5.0) #3564

CAPSTONE-NG (AFTER 5.0) #3564

Conversation

XVilka commented Jun 8, 2023 • edited Loading

XVilka commented Jun 30, 2023

This comment was marked as resolved.

This comment was marked as outdated.

XVilka commented Jul 5, 2023

imbillow commented Jul 5, 2023 • edited Loading

Rot127 commented Jul 5, 2023

XVilka commented Jul 6, 2023

XVilka commented Jul 6, 2023

XVilka commented Jul 7, 2023

XVilka commented Jul 15, 2023

XVilka commented Jun 8, 2023 •

edited

Loading

imbillow commented Jul 5, 2023 •

edited

Loading