Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ARM] Update to Capstone v6/auto-sync #3591

Closed
wants to merge 53 commits into from
Closed

[ARM] Update to Capstone v6/auto-sync #3591

wants to merge 53 commits into from

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Jun 19, 2023 •
edited
Loading

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Updates the ARM modules to Capstone's v6/auto-sync version.

Depends on: capstone-engine/capstone#1949

Test plan

All green

Closing issues

...

@Rot127 Rot127 mentioned this pull request Jun 19, 2023
Closed
5 tasks
@Rot127 Rot127 added this to the 0.7.0 milestone Jun 19, 2023
@XVilka
Copy link
Member

XVilka commented Jun 20, 2023

  1. Please resolve conflicts
  2. Ideally we should reduce the amount of BROKEN tests to zero (that were added after the capstone update)

@XVilka
Copy link
Member

XVilka commented Jun 27, 2023

@Rot127 there are a lot of similar issues with the same error: [rizin: ../subprojects/capstone-auto-sync-arm/arch/ARM/ARMGenAsmWriter.inc:12377: getRegisterName: Assertion RegNo && RegNo < 296 && "Invalid register number!"' failed.`

@XVilka
Copy link
Member

XVilka commented Jul 4, 2023

Should this use capstone-ng as a base instead?
See:

@Rot127 Rot127 changed the base branch from dev to capstone-ng July 4, 2023 09:29
@github-actions github-actions bot removed documentation Improvements or additions to documentation infrastructure API RzAsm-Disassembler labels Jul 4, 2023
@Rot127 Rot127 marked this pull request as ready for review July 4, 2023 21:49
XVilka
XVilka requested changes Jul 5, 2023
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks much cleaner now, it's great!
A lot of tests failed at Windows though: https://ci.appveyor.com/project/rizinorg/rizin/builds/47465331/job/8i6ykhf360gn4d74

meson.build Outdated Show resolved Hide resolved
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 6, 2023
@Rot127
Another post_index
d97aa4b
@Rot127
Fix 8 byte stores.
bc08e63
@Rot127
Add flag checking for MOV with shifts.
2a4cf01
@Rot127
Revert "[REVERT ME] Add auto-sync Capstone"
6d6a048 
This reverts commit b86eb6d.
@Rot127
Remove capstone-auto-sync subproject and replace with next
be42601
@Rot127
Fix rebase mistakes
7781cec
@Rot127
Check for NEON features.
3c5fc45
@Rot127
Fix tests where ldr was replaced with pop
d51cf41
@Rot127
Fix postindex 8byte store
7229d5a
@Rot127
Remove unreachable code for ESIL LDR.
cbe6366
@Rot127
Fix flag check/set of mov instructions with shift.
17ca894
@Rot127
Check for subtracted flag of mem.disp.
2c0d744
@Rot127
Use macro for disp access
a0e905f
@Rot127
Fix function variable recognition.
7fc913c 
The variable should not added if sp was only moved.
@Rot127
Fix json tests
9c220a0
@Rot127
Fix new id
61f65fe
@Rot127
Fix post-index ldrd esil instructions
8c039b4
@Rot127
Fix ARM64 tests by separating their esil condition code.
75a7ff2
@Rot127
Fix shift of post index stores
837dcb5
@Rot127
Fix more post index memory instructions.
f7d50db
@Rot127
Fix invalid variable recognition.
5afd6f8
@Rot127
Use capstone-engine/capstone#2122 for better system operand support.
50bc8b3
@Rot127
Distinguish between 32 and 64bit cc check.
ed2a3dd
@Rot127
Check for CS API version >5
18dc5d7
@Rot127
Check for CS_NEXT_VERSION instead of CS_API_MAJOR.
23c371c
@Rot127
Fix VSTn and VLDn instructions to use corrected memory operands.
3341388
@Rot127
Fix incorrect tests with missing writeback due to missing post-index …
327ef81 
…flag
@Rot127
Copy link
Member Author

Rot127 commented Sep 20, 2023

Closed in favor of #3648

@Rot127 Rot127 closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka requested changes

@wargio wargio Awaiting requested review from wargio wargio is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@Heersin Heersin Awaiting requested review from Heersin

Assignees
No one assigned
Labels
ARM capstone rz-test RzAnalysis
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Rot127 @XVilka @Heersin