Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mui: fix gap in outline when label is hidden #3984

Merged
merged 2 commits into from
Dec 1, 2023
Merged

mui: fix gap in outline when label is hidden #3984

merged 2 commits into from
Dec 1, 2023

Commits on Nov 30, 2023

  1. mui: fix gap in outline when label is hidden 

    Passing `label={false}` to the MUI text/select widgets results in a
gap in the widget outline where the label would be.  Instead, to hide
the label without a gap, we must pass `label={undefined}`.

This commit changes the calls to `labelValue(...)` for
BaseInputTemplatea and SelectWidget to return `undefined` when
`"ui:label": false` was specified.
    @drbild
    drbild committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    0563e3f View commit details
    Browse the repository at this point in the history

  2. mui: update test snapshots

    @drbild
    drbild committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    b4762ed View commit details
    Browse the repository at this point in the history