Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mui: fix gap in outline when label is hidden #3984

Merged
merged 2 commits into from
Dec 1, 2023
Merged

mui: fix gap in outline when label is hidden #3984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0563e3f
mui: fix gap in outline when label is hidden
drbild Nov 30, 2023
b4762ed
mui: update test snapshots
drbild Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ should change the heading of the (upcoming) version to include a major version b
-->
# 5.15.0

## @rjsf/mui

- fix gap in text and select widget outlines when `"ui:label": false` is specified.

## @rjsf/utils

- Added an experimental flag `allOf` to `experimental_defaultFormStateBehavior` for populating defaults when using `allOf` schemas [#3969](https://github.com/rjsf-team/react-jsonschema-form/pull/3969)
Expand Down
2 changes: 1 addition & 1 deletion packages/mui/src/BaseInputTemplate/BaseInputTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export default function BaseInputTemplate<
id={id}
name={id}
placeholder={placeholder}
label={labelValue(label || undefined, hideLabel, false)}
label={labelValue(label || undefined, hideLabel, undefined)}
autoFocus={autofocus}
required={required}
disabled={disabled || readonly}
Expand Down
2 changes: 1 addition & 1 deletion packages/mui/src/SelectWidget/SelectWidget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export default function SelectWidget<
<TextField
id={id}
name={id}
label={labelValue(label || undefined, hideLabel, false)}
label={labelValue(label || undefined, hideLabel, undefined)}
value={!isEmpty && typeof selectedIndexes !== 'undefined' ? selectedIndexes : emptyValue}
required={required}
disabled={disabled || readonly}
Expand Down
Loading