Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM: Deprecate ContainerFactory#FromAny() method #73

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

rkosegi
Copy link
Owner

@rkosegi rkosegi commented Aug 28, 2024

This should never be part of this interface.
Its implementation is very opiononated and can be achieved by various ways
by caller. Deprecate and remove it later.

Signed-off-by: Richard Kosegi richard.kosegi@gmail.com

This should never be part of this interface.
Its implementation is very opiononated and can be achieved by various ways
by caller. Deprecate and remove it later.

Signed-off-by: Richard Kosegi <richard.kosegi@gmail.com>
Copy link

sonarcloud bot commented Aug 28, 2024

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.41%. Comparing base (bc350e0) to head (8e5449e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   99.41%   99.41%           
=======================================
  Files          46       46           
  Lines        2213     2213           
=======================================
  Hits         2200     2200           
  Misses          6        6           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkosegi rkosegi merged commit c0844c3 into main Aug 28, 2024
4 checks passed
@rkosegi rkosegi deleted the feature/dom-deprecated-from-any branch August 28, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant