Move from git-mob cli to api #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing this will prevent the need to install the cli to use vs code version. - convert git-author tests from AVA to Jest
Had to change for get accessors to async methods to handle promises.
Still need to update the template file. silentRun no longer catchs errors and that is for handleResponse to take care of.
list all authors in a Map, make it easy to access and iterate through authors.
Array methods provide a more common way to access authors.
Improve naming repoAuthorList function
Check co-authors is formatted and passed to append function.
Remove unused commands for fetch co authors from git config.
remove unused cli function to change primary authors.
Add via Git local repo, GitHub and manual input Removed add co-author cli command Removed manage features edit-co-author and remove-co-author. Not needed for the vs-code.
File only added if it does not exist. Removed check for cli version and install commands.
rkotze
added
the
Code improvements
Remove the need for Git Mob CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading from the CLI can fail because it's not accessible using
npx.I think the best approach might be to build Git Mob API and remove the need to install
git-mob. It will still work with the CLI by keeping the same behaviour.API improvments
Task list
.git-co-authorfileShould fix PR #49