Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: run yarn lint #1486

Merged
merged 2 commits into from
Aug 9, 2021
Merged

style: run yarn lint #1486

merged 2 commits into from
Aug 9, 2021

Conversation

lisabaut
Copy link
Contributor

@lisabaut lisabaut commented Aug 6, 2021

Description

I tried out some scripts and saw that when running yarn lint from the root folder a lot of files are formatted.
So I thought I simply commit them in the hope this formatting should actually be like that?

Note

I further noticed that running yarn lint from the root only works without errors if the node_modules within the folder example are empty/not yet installed. If the node_modules in the directory example exist the following error occurs when running yarn lint from the root:

Error: Cannot read config file: maps/example/node_modules/eslint-config-prettier/@typescript-eslint.js
Error: "prettier/@typescript-eslint" has been merged into "prettier" in eslint-config-prettier 8.0.0. See: https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md#version-800-2021-02-21
Referenced from: maps/example/.eslintrc.js
    ....
error Command failed with exit code 2.

I would dig deeper into this and open another PR at some point. Shall i open an issue for that?

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I updated the documentation yarn generate
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (index.d.ts)
  • I added/ updated a sample (/example)

Screenshot OR Video

@ferdicus
Copy link
Member

ferdicus commented Aug 9, 2021

Looks good 👍🏿

@ferdicus ferdicus merged commit db7c5ec into rnmapbox:master Aug 9, 2021
mikalaiulasevich pushed a commit to OneSoil-Platform/maps that referenced this pull request Sep 23, 2021
* style: run yarn lint

* chore: update Changelog
mikalaiulasevich pushed a commit to OneSoil-Platform/maps that referenced this pull request Sep 23, 2021
* style: run yarn lint

* chore: update Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants