Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(interceptors): gRPC interceptors support #69

Merged
merged 3 commits into from
Feb 2, 2023

Conversation

cv65kr
Copy link
Member

@cv65kr cv65kr commented Feb 2, 2023

Reason for This PR

roadrunner-server/roadrunner#1313

Is first step to create OTEL plugin for GRPC.

image

Description of Changes

This PR introduce possibility to have own middleware (interceptors) for GRPC server.

License Acceptance

I used package based on Apache2 licence, I am not sure if this impacting RR licence.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian self-requested a review February 2, 2023 00:17
@rustatian rustatian added the enhancement New feature or request label Feb 2, 2023
@rustatian rustatian changed the title Middleware for GRPC feature(interceptors): gRPC interceptors support Feb 2, 2023
@rustatian
Copy link
Member

Hey @cv65kr 👋🏻
It's a very nice feature :) The funny thing is I have a local PR with almost the same code 😄 But I have no time to push it to the upstream.

@cv65kr
Copy link
Member Author

cv65kr commented Feb 2, 2023

@rustatian 😄 I prepared also changes for otel grpc, I will ping you tomorrow to get some aggrement how we want to processed with it.

And generally looks like i screw it github history, so tomorrow will fix it.

common/interfaces.go Outdated Show resolved Hide resolved
server.go Outdated Show resolved Hide resolved
@rustatian
Copy link
Member

@rustatian smile I prepared also changes for otel grpc, I will ping you tomorrow to get some aggrement how we want to processed with it.

And generally looks like i screw it github history, so tomorrow will fix it.

I'll be glad to help 🤝.
This might be a part of this ticket: roadrunner-server/roadrunner#1313

@rustatian rustatian self-requested a review February 2, 2023 01:09
@rustatian
Copy link
Member

Good work 👍🏻 Thanks @cv65kr

@rustatian rustatian merged commit 3a00b14 into roadrunner-server:master Feb 2, 2023
@rustatian
Copy link
Member

The last thing is...... docs 😄
But that might be done with the OTEL gRPC Interceptor PR because you might add it as an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants