Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for opentelemetry - gRPC, Temporal #240

Merged
merged 7 commits into from
Feb 6, 2023

Conversation

cv65kr
Copy link
Member

@cv65kr cv65kr commented Feb 4, 2023

Reason for This PR

Tests for:

Description of Changes

Testing cases

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@cv65kr cv65kr changed the title Feat/grpc temporal otel Tests for opentelemetry - gRPC, Temporal Feb 4, 2023
@cv65kr cv65kr force-pushed the feat/grpc-temporal-otel branch 2 times, most recently from 6da7801 to abdba8f Compare February 4, 2023 18:26
@rustatian rustatian self-requested a review February 4, 2023 18:31
@rustatian rustatian added the enhancement New feature or request label Feb 4, 2023
@rustatian
Copy link
Member

rustatian commented Feb 4, 2023

Hey @cv65kr 👋🏻

Have you tested that locally?

EDIT: I'll move it to draft until I tag all releases.

@rustatian rustatian marked this pull request as draft February 4, 2023 18:33
@rustatian
Copy link
Member

BTW, you may install golangci-lint locally and check the code before committing the changes (optional for sure).
Here is the tutorial: https://golangci-lint.run/usage/install/
And after installation just execute: golangci-lint --build-tags=race run

@cv65kr
Copy link
Member Author

cv65kr commented Feb 4, 2023

@rustatian yes, all tested. Ok will install this linter and push one more commit.

And yes unfortunately because of releases I used "replace".

@rustatian
Copy link
Member

Ok will install this linter and push one more commit.

Yeah, you may save a few minutes waiting for the CI results on the GitHub actions side 😃

@cv65kr
Copy link
Member Author

cv65kr commented Feb 4, 2023

Looks like yaml files was not pushed somehow 🤔

@cv65kr
Copy link
Member Author

cv65kr commented Feb 4, 2023

@rustatian PR updated, looks like some tests failed but there are not related with my changes.

@rustatian
Copy link
Member

@cv65kr Ok, all PRs are merged and tagged ⚡

@cv65kr cv65kr force-pushed the feat/grpc-temporal-otel branch from 3fca50c to 3644300 Compare February 6, 2023 14:24
@cv65kr
Copy link
Member Author

cv65kr commented Feb 6, 2023

@rustatian updated 😄

@rustatian rustatian marked this pull request as ready for review February 6, 2023 14:25
@rustatian
Copy link
Member

@cv65kr One note, you have to use the stderr collector for the otel plugin and capture the output, not from the stdout. This is done, because the >= Go 1.19.5 captures the coverage from the stdout, but we're closing it in the tests. You may look at the plugins/http/otel tests which I recently updated.

@cv65kr
Copy link
Member Author

cv65kr commented Feb 6, 2023

@rustatian alright, done

@rustatian
Copy link
Member

Thanks @cv65kr 👍🏻

@rustatian rustatian merged commit c4db99e into roadrunner-server:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants