-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for opentelemetry - gRPC, Temporal #240
Tests for opentelemetry - gRPC, Temporal #240
Conversation
6da7801
to
abdba8f
Compare
Hey @cv65kr 👋🏻 Have you tested that locally? EDIT: I'll move it to draft until I tag all releases. |
BTW, you may install |
@rustatian yes, all tested. Ok will install this linter and push one more commit. And yes unfortunately because of releases I used "replace". |
Yeah, you may save a few minutes waiting for the CI results on the GitHub actions side 😃 |
Looks like yaml files was not pushed somehow 🤔 |
@rustatian PR updated, looks like some tests failed but there are not related with my changes. |
@cv65kr Ok, all PRs are merged and tagged ⚡ |
3fca50c
to
3644300
Compare
@rustatian updated 😄 |
@cv65kr One note, you have to use the |
@rustatian alright, done |
Thanks @cv65kr 👍🏻 |
Reason for This PR
Tests for:
gRPC
plugin otel#40gRPC
interceptors support grpc#69Description of Changes
Testing cases
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.