Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: temporal interceptors support #41

Merged

Conversation

cv65kr
Copy link
Member

@cv65kr cv65kr commented Feb 4, 2023

Reason for This PR

roadrunner-server/roadrunner#1313

Description of Changes

Telemetry for Temporal
image

PART1: temporalio/roadrunner-temporal#322

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

plugin.go Outdated Show resolved Hide resolved
temporal_interceptor.go Outdated Show resolved Hide resolved
plugin.go Outdated Show resolved Hide resolved
@rustatian rustatian changed the title Temporal support feature: temporal interceptors support Feb 4, 2023
@rustatian rustatian added the enhancement New feature or request label Feb 4, 2023
@rustatian
Copy link
Member

Hey @cv65kr 👋🏻

It would be nice to have tests for the new otel functionality (grpc and temporal). You may use a stderr collector and redirect the stderr in the buffer like I did here link. And then check for some otel-specific fields in the output.

plugin.go Outdated Show resolved Hide resolved
@cv65kr
Copy link
Member Author

cv65kr commented Feb 4, 2023

Fair point about naming - done.

Yep, will write some tests.

@cv65kr
Copy link
Member Author

cv65kr commented Feb 6, 2023

@rustatian updated and tested as well

@rustatian rustatian marked this pull request as ready for review February 6, 2023 14:02
Copy link
Member

@rustatian rustatian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rustatian
Copy link
Member

Nice, thank you @cv65kr 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants