-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: temporal interceptors support #41
Merged
rustatian
merged 5 commits into
roadrunner-server:master
from
cv65kr:feat/temporal-interceptors
Feb 6, 2023
Merged
feature: temporal interceptors support #41
rustatian
merged 5 commits into
roadrunner-server:master
from
cv65kr:feat/temporal-interceptors
Feb 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustatian
requested changes
Feb 4, 2023
rustatian
reviewed
Feb 4, 2023
Fair point about naming - done. Yep, will write some tests. |
6 tasks
cv65kr
force-pushed
the
feat/temporal-interceptors
branch
from
February 6, 2023 12:40
33cae7d
to
584729c
Compare
@rustatian updated and tested as well |
rustatian
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice, thank you @cv65kr 👍🏻 |
Merged
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This PR
roadrunner-server/roadrunner#1313
Description of Changes
Telemetry for Temporal
PART1: temporalio/roadrunner-temporal#322
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]
git commit -s
).CHANGELOG.md
.