Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: opentelemetry for the gRPC plugin #40

Merged
merged 6 commits into from
Feb 3, 2023

Conversation

cv65kr
Copy link
Member

@cv65kr cv65kr commented Feb 3, 2023

Reason for This PR

roadrunner-server/roadrunner#1313

Description of Changes

Possibility to use telemetry for gRPC

Doc: roadrunner-server/roadrunner-docs#127

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian changed the title Opentelemetry for gRPC feature: opentelemetry for the gRPC plugin Feb 3, 2023
@rustatian rustatian self-requested a review February 3, 2023 14:36
@rustatian rustatian added the enhancement New feature or request label Feb 3, 2023
@rustatian
Copy link
Member

Hey @cv65kr 👋🏻
Nice 👍🏻

One note, in the v2023 we're going to move the otel configuration out of the http. It should be available like a plugin's configs as a top yaml key.

plugin.go Outdated Show resolved Hide resolved
plugin.go Outdated Show resolved Hide resolved
plugin.go Outdated Show resolved Hide resolved
plugin.go Outdated Show resolved Hide resolved
@cv65kr
Copy link
Member Author

cv65kr commented Feb 3, 2023

@rustatian I pushed one small change for propagators, now should looks like final PR

Copy link
Member

@rustatian rustatian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants