-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add per-class counting to LineZone, create LineZoneAnnotatorMulticlass #1555
Conversation
Hi @onuralpszr 👋 If you have some time, can you skim through this one, see if anything stands out? |
Hello 👋 let me setup and try out sure |
Example results: out_normal_optim.mp4 |
Video not loading* |
My Review/Test Branch
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some optimizations I think it is better to use in this case
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
Accepted the refactor:
At the end of the day - some subjective changes and I don't mind, and some very welcome improvements. Thank you very much @onuralpszr ! Will merge it after giving it another couple of runs. |
Description
This PR adds per-class counting capabilities to
LineZone
.The results can be visualized with the newly added
LineZoneAnnotatorMultiClass
.Type of change
Please delete options that are not relevant.
How has this change been tested, please provide a testcase or example of how you tested the change?
Rigorously tested locally.
Colab
Known issues that are NOT to be addressed as part of this PR:
Any specific deployment considerations
Docs
in_count
,out_count
are now propertiesin_count_per_class
,out_count_per_class
LineZoneAnnotatorMulticlass