Add build = false to Cargo.toml to fix nightly breakage
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rust-lang/rust#40197 it was discovered that this crate no longer builds on nightly due to a rust-lang/cargo#3664 where Cargo will now infer that `build.rs` is a build script unless explicitly configured with `build = false`. Currently we're not intending to revert the Cargo change, but let me know if this causes trouble though and we can certainly reconsider!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rust-lang/rust#40197 it was discovered that this crate no longer builds on
nightly due to a rust-lang/cargo#3664 where Cargo will now infer that
build.rsis a build script unless explicitly configured with
build = false.Currently we're not intending to revert the Cargo change, but let me know if
this causes trouble though and we can certainly reconsider!