Assume that a build.rs file is a build script
#3664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If cargo sees a `build.rs` file in the same directory as the current `Cargo.toml`, it will assume that the `build.rs` file is a build script, _unless there is_ `build = false` _in the _ `Cargo.toml` _file_. Closes rust-lang#3391
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ Thanks! |
|
📌 Commit 952b0ab has been approved by |
bors
added a commit
that referenced
this pull request
Feb 7, 2017
Assume that a `build.rs` file is a build script If cargo sees a `build.rs` file in the same directory as the current `Cargo.toml`, it will assume that the `build.rs` file is a build script, unless there is `build = false` in the `Cargo.toml` file. Closes #3391
|
☀️ Test successful - status-appveyor, status-travis |
alexcrichton
added a commit
to alexcrichton/roboime-next
that referenced
this pull request
Mar 9, 2017
In rust-lang/rust#40197 it was discovered that this crate no longer builds on nightly due to a rust-lang/cargo#3664 where Cargo will now infer that `build.rs` is a build script unless explicitly configured with `build = false`. Currently we're not intending to revert the Cargo change, but let me know if this causes trouble though and we can certainly reconsider!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If cargo sees a
build.rsfile in the same directory as the currentCargo.toml, it will assume that thebuild.rsfile is a build script,unless there is
build = falsein theCargo.tomlfile.Closes #3391