-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only sync release if there is a difference #205
Comments
@kody-abe Hey! Thanks for the request. Would you mind clarifying a bit more, on pros of your requested feature over just |
@mumoshu I guess maybe the terraform style. Showing all the changes and then asking for confirmation. Currently, our team will just have a policy to run the diff first verify the changes are as expected and then run sync. I can see the value in having sync, or another command, run the diff and present it if changes are found, then ask if the command should continue with sync. |
One pro of only doing the updates is not upgrading every release in the helmfile. If you had a automated system that ran on say a 5 min interval you would end up with thousands of releases, but if it only upgraded on releases that changed it would work cleanly. |
@kody-abe Thanks for the clarification! Just to make it extra clear, you're talking about non-CI use-case, that is, helmfile is run by humans so interactive confirmation makes sense, right? |
@mumoshu Correct! |
@sstarcher Good point! It would be a good enhancement. Just a moment until I come up with something... |
@sstarcher @kody-abe How about adding I'm introducing a brand-new command to retain backward-compatibility while giving more terraform-like u/x to helmfile with (from my perspective) a more appropriate name. // Regarding the last point, I remember that I had once felt a bit ambiguity in the "direction" of
|
@mumoshu Yes, |
@kody-abe Thanks a lot for the confirmations 👍 |
Sounds good to me, I'm good with either, but due to it seems people being familiar with terraform I would lean toward |
This command syncs releases only if there is any difference between the desired and the current state. It asks for an confirmation by default. Provide `--auto-approve` flag after the `apply` command to skip it. Resolves roboll#205
Just submitted #263 for this. I've proceeded with |
This command syncs releases only if there is any difference between the desired and the current state. It asks for an confirmation by default. Provide `--auto-approve` flag after the `apply` command to skip it. Resolves roboll#205
This command syncs releases only if there is any difference between the desired and the current state. It asks for an confirmation by default. Provide `--auto-approve` flag after the `apply` command to skip it. Resolves #205
Any possibility of adding a feature to run the sync for releases in the helmfile that have differences.
With the feature of
helm diff
I would imagine this would be something that would fit?The text was updated successfully, but these errors were encountered: