Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shouldn't apply run sync against only releases that has any changes? #277

Closed
mumoshu opened this issue Sep 2, 2018 · 0 comments
Closed

Shouldn't apply run sync against only releases that has any changes? #277

mumoshu opened this issue Sep 2, 2018 · 0 comments
Labels
bug design finalized

Comments

@mumoshu
Copy link
Collaborator

mumoshu commented Sep 2, 2018 •
edited
Loading

The current flow of apply is:

For each helmfile found via helmfiles: or helmfile.d or --f helmfile.yaml:

  • diff all the releases in the helmfile
  • if there are any changes in any releases, sync all the releases in the helmfile

This looks to defeat the one of original purposes of apply, that is to upgrade only the releases that has any changes #205 (comment).

The latter part should be changed to:

  • if there are any changes in any releases, sync only the releases that has any changes in the helmfile
@mumoshu mumoshu added the bug label Sep 2, 2018
@mumoshu mumoshu changed the title Shouldn't apply do diff and then sync for each release? Shouldn't apply run sync only releases that has any changes? Sep 2, 2018
@mumoshu mumoshu changed the title Shouldn't apply run sync only releases that has any changes? Shouldn't apply run sync against only releases that has any changes? Sep 3, 2018
mumoshu added a commit to mumoshu/helmfile that referenced this issue Sep 4, 2018
@mumoshu
feat: apply run sync against only affected releases
9aaf4f1 
Enhance the `diff` functionality to be able to return affected releases that has any changes,
so that the succeeding `sync` can be run against only the affected releases.

This provides us extra idempotency.

Resolves roboll#277
@mumoshu mumoshu mentioned this issue Sep 4, 2018
Merged
mumoshu added a commit that referenced this issue Sep 4, 2018
@mumoshu
feat: apply run sync against only affected releases (#291)
f1ac50b 
Enhance the `diff` functionality to be able to return affected releases that has any changes,
so that the succeeding `sync` can be run against only the affected releases.

This provides us extra idempotency.

Resolves #277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug design finalized
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mumoshu