Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paths should be relative to that of helmfile.yaml #246

Closed
mumoshu opened this issue Aug 29, 2018 · 2 comments
Closed

Paths should be relative to that of helmfile.yaml #246

mumoshu opened this issue Aug 29, 2018 · 2 comments

Comments

@mumoshu
Copy link
Collaborator

mumoshu commented Aug 29, 2018

In the example below:

releases:
- name: myapp
  chart: ./myapp/charts/myapp
  values:
  - ./myapp/values.yaml
  secrets:
  - ./myapp/secrets.yaml

I would expect helmfile -f path/to/helmfile.yaml to resolve all the paths included in the file to be under the directory path/to. As of today helmfile resolves it relative to CWD.

@mumoshu
Copy link
Collaborator Author

mumoshu commented Aug 29, 2018

Beware that we can't just automatically cd into the directory the targeted helmfile.yaml is in, not to resurrect #173

@mumoshu
Copy link
Collaborator Author

mumoshu commented Aug 30, 2018

This seems to affect lint, but sync. Unsure about other commands yet.

mumoshu added a commit to mumoshu/helmfile that referenced this issue Aug 30, 2018
`helmfile lint` works with relative chart reference (roboll#252)
The tempalte function `readFile` accepts the path relative to helmfile.yaml

Resolves roboll#246
Fixes roboll#252
mumoshu added a commit that referenced this issue Aug 30, 2018
`helmfile lint` works with relative chart reference (#252)
The tempalte function `readFile` accepts the path relative to helmfile.yaml

Resolves #246
Fixes #252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant