feat: All the paths are relative to helmfile.yaml #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`helmfile lint` works with relative chart reference (roboll#252) The tempalte function `readFile` accepts the path relative to helmfile.yaml Resolves roboll#246 Fixes roboll#252
mumoshu
added a commit
to mumoshu/helmfile
that referenced
this pull request
Aug 30, 2018
Fixes for the bugs that are introduced by roboll#261, that is values.yaml files specified in `values:` have redundant base path in their prefixes, and remaining .dec files after secrets decryption(roboll#251 (comment))
mumoshu
added a commit
that referenced
this pull request
Aug 30, 2018
Fixes for the bugs that are introduced by #261, that is values.yaml files specified in `values:` have redundant base path in their prefixes, and remaining .dec files after secrets decryption(#251 (comment))
dtshepherd
reviewed
Sep 19, 2018
| return chart | ||
| } | ||
| return filepath.Join(basePath, chart) | ||
| } | ||
|
|
||
| func isLocalChart(chart string) bool { | ||
| regex, _ := regexp.Compile("^[.]?./") |
There was a problem hiding this comment.
@mumoshu Is there a reason a / is required to be a local chart? Its seems valid to have the helmfile.yaml in the same folder as a local chart:
├── Chart.yaml
├── charts
│ ├── grafana-1.14.7.tgz
│ ├── influxdb-0.11.0.tgz
│ ├── kapacitor-1.1.0.tgz
│ ├── telegraf-ds-1.7.4.tgz
│ └── telegraf-s-1.7.4.tgz
├── helmfile.d
│ └── helmfile.yaml
And the helmfile.yaml:
releases:
- name: myrelease
chart: ..
I'd expect the regex to just be ^[.].
There was a problem hiding this comment.
For now, I can work around this by adding a trailing slash / to my chart path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helmfile lintworks with relative chart reference (#252)The tempalte function
readFileaccepts the path relative to helmfile.yamlResolves #246
Fixes #252