Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change to helmfile template so it respects logging levels #1691

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

chrismellard
Copy link
Contributor

No description provided.

@jstrachan
Copy link
Contributor

@mumoshu any chance of a review please? its a fairly simple change ;)

Copy link
Collaborator

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @chrismellard and @jstrachan!

@mumoshu mumoshu merged commit e9d1c85 into roboll:master Mar 23, 2021
@mumoshu
Copy link
Collaborator

mumoshu commented Mar 24, 2021

@chrismellard @jstrachan Hey! I started to think we need to revert this. What is this change supposed to do, and for which use-case(s) do you need this patch?

I think I've completely misread this patch while reviewing- To me, this looks to break helmfile template or helmfile template > all.yaml completely, due to that its output is now flowing into stderr instead of stdout. This can be also confirmed by CI builds failing since this change.

@jstrachan
Copy link
Contributor

@mumoshu ah ok! the main aim was to be able to tone down the logging levels of helmfile template to avoid pages of output of every helm template command for every release + every file in every chart being written to a file - it wasn't attempting to modify the semantics of stdout/stderr.

I wonder if there's better way to keep the same logging level of helm?

@mumoshu
Copy link
Collaborator

mumoshu commented Mar 24, 2021

@jstrachan Ah gotcha! Thanks for clarifying.

I wonder if there's better way to keep the same logging level of helm?

Yeah probably- How about forcing writes to stdout when and only when --output-dir is NOT passed to helm template?

mumoshu added a commit that referenced this pull request Mar 25, 2021
This fixes #1691 by redirecting helm-template output to our logger when and only when --output-dir is being passed to helm-template.

See #1691 (comment) for more context.
mumoshu added a commit that referenced this pull request Mar 25, 2021
This fixes #1691 by redirecting helm-template output to our logger when and only when --output-dir is being passed to helm-template.

See #1691 (comment) for more context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants