Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helmfile-template not writing to stdout #1737

Merged
merged 1 commit into from
Mar 25, 2021

Conversation

mumoshu
Copy link
Collaborator

@mumoshu mumoshu commented Mar 25, 2021

This fixes #1691 by redirecting helm-template output to our logger when and only when --output-dir is being passed to helm-template.

See #1691 (comment) for more context.

This fixes #1691 by redirecting helm-template output to our logger when and only when --output-dir is being passed to helm-template.

See #1691 (comment) for more context.
@mumoshu
Copy link
Collaborator Author

mumoshu commented Mar 25, 2021

@jstrachan @chrismellard Would this be what you wanted originally? I'm fixing #1691 this way so that you can still use helmfile template | kubectl apply -f -, while enabling to prevent excessive logs when using --output-dir like helmfile --log-level=error template --output-dir path/to/dir.

@mumoshu mumoshu merged commit faa7496 into master Mar 25, 2021
@mumoshu mumoshu deleted the fix-helmfile-template-not-wrinting-to-stdout branch March 25, 2021 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant