Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amc v1.6, ems v3.81, mc2plus v3.63, mc4plus v3.84, 2foc v3.3.22 #118

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Nov 24, 2023

amc v1.6, ems v3.81, mc2plus v3.63, mc4plus v3.84, 2foc v3.4.0

The new features added in these binaries, as described in the PRs mentioned below, can be summed up as follows:

  • it is now possible to pass hardware and warning temperature limits and temperature sensor type through the configuration files
    • this allows the user to define a hardware temperature limit (typically 100 ℃) that cannot be overcome by the motor while in working conditions. its overcome will trigger a fault stopping the motor.
    • this allows the user to define a warning temperature limit that allows to send just a warning error when the limit is overcome. As mentioned in the specific PR, the warning limit must be lower than 85% of the hardware temperature limit.
    • this allows the user to read the temperature values on a yarp port using a rf module that calls the getTemperature api, the temperature values are read on the I2C by the foc board with a routine of 207Hz and the read value is sent up to the ems and then to the icub-main level with a frequency of 10Hz.
  • ems can manage forming of the CAN message containing the temperature limits to be sent to the foc board to handle the temperature control and eventually trigger the hardware temperature limit reaching
  • ems can manage the parsing of the CAN message containing the temperature values coming from the foc board and to be sent to the higher level

More details available at the PRs linked below.

Related PR:

@MSECode MSECode marked this pull request as draft November 24, 2023 15:07
@MSECode MSECode self-assigned this Nov 24, 2023
@MSECode MSECode changed the base branch from master to devel November 27, 2023 07:40
@MSECode MSECode changed the title Feature/temperature reading amc v1.6, ems v3.81, mc2plus v3.63, mc4plus v3.84 Nov 27, 2023
@MSECode MSECode changed the title amc v1.6, ems v3.81, mc2plus v3.63, mc4plus v3.84 Update amc v1.6, ems v3.81, mc2plus v3.63, mc4plus v3.84, 2foc v3.4.0 Nov 27, 2023
@marcoaccame marcoaccame changed the title Update amc v1.6, ems v3.81, mc2plus v3.63, mc4plus v3.84, 2foc v3.4.0 amc v1.6, ems v3.81, mc2plus v3.63, mc4plus v3.84, 2foc v3.4.0 Nov 27, 2023
@marcoaccame
Copy link
Contributor

hi @MSECode, it seems fine. when ok to start the merging of firmware, firmware-shared and firmware-build, pls let me know.

@MSECode
Copy link
Contributor Author

MSECode commented Nov 28, 2023

Tested and working fine

@MSECode
Copy link
Contributor Author

MSECode commented Nov 28, 2023

Finally release version of 2foc v3.3.22, so that not increasing the minor it is possible to do not have to change old config file and fw can accept configurations with different foc versions that changes only the build version. Same for the CAN protocol that is kept to 1.6

cc: @valegagge @marcoaccame

@MSECode MSECode marked this pull request as ready for review November 28, 2023 11:55
@MSECode MSECode changed the title amc v1.6, ems v3.81, mc2plus v3.63, mc4plus v3.84, 2foc v3.4.0 amc v1.6, ems v3.81, mc2plus v3.63, mc4plus v3.84, 2foc v3.3.22 Nov 28, 2023
@marcoaccame marcoaccame merged commit e06014e into robotology:devel Nov 28, 2023
marcoaccame added a commit to marcoaccame/icub-firmware-build that referenced this pull request Dec 19, 2023
@MSECode MSECode deleted the feature/temperatureReading branch March 21, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants