Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Started work for temperature reading #89

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Started work for temperature reading #89

merged 2 commits into from
Nov 28, 2023

Conversation

MSECode
Copy link
Contributor

@MSECode MSECode commented Oct 24, 2023 •
edited
Loading

The PR brings the following changes:

  • new eoerror_value_MC_motor_overheating MC error type introduced
  • new ICUBCANPROTO_POL_MC_CMD__SET_TEMPERATURE_LIMIT polling MC message introduced for sending temperature limits to foc boards
  • with all of that increased the icub_firmware_shared version to 1.37.2

@MSECode MSECode self-assigned this Oct 24, 2023
@MSECode MSECode marked this pull request as draft October 24, 2023 10:08
@MSECode
Copy link
Contributor Author

MSECode commented Oct 24, 2023

Need to do: update the icub-firmware-shared version for CMakeFiles.txt
Is that correct @valegagge

@pattacini pattacini mentioned this pull request Oct 24, 2023
Merged
valegagge
valegagge requested changes Nov 3, 2023
View reviewed changes
Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Justa a small thing to change.

eth/embobj/plus/comm-v2/icub/EoError.c Outdated Show resolved Hide resolved
@MSECode
Started work for temperature reading
effc8ad 
Add new MC error code+string entry for temperature limit overcoming
@MSECode MSECode mentioned this pull request Nov 27, 2023
Merged
valegagge
valegagge approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valegagge valegagge marked this pull request as ready for review November 27, 2023 13:29
marcoaccame
marcoaccame approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is ok, thanks.

@valegagge valegagge merged commit 2f4c903 into robotology:devel Nov 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoaccame marcoaccame marcoaccame approved these changes

@valegagge valegagge valegagge approved these changes

Assignees

@MSECode MSECode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MSECode @valegagge @marcoaccame