-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EoInertials3: refactor in order to make it work also w/ ems and mtb3. #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicogene
changed the title
WIP refactor eotheinertials3
EoInertials3: refactor in order to make it work also w/ ems and mtb4.
Nov 13, 2023
4 tasks
Nicogene
changed the title
EoInertials3: refactor in order to make it work also w/ ems and mtb4.
EoInertials3: refactor in order to make it work also w/ ems and mtb3.
Nov 13, 2023
Nicogene
force-pushed
the
refactorEOInertials3
branch
from
November 15, 2023 15:02
79295bf
to
a63cb5e
Compare
… board but it is failing
Nicogene
force-pushed
the
refactorEOInertials3
branch
from
November 23, 2023 09:05
837928f
to
3044c0f
Compare
Nicogene
added a commit
to robotology/icub-firmware-build
that referenced
this pull request
Nov 23, 2023
Built w/ icub-firmware-shared@9ba514d46c013ebe5855a80be1321346d814e8b2 and icub-firmware@ffb06fc2d9febb6948f196d0c582d5c9cf071d12 See robotology/icub-firmware#439
marcoaccame
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thanks
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates in
EoInertials3
the functionalities ofEoInertials2
. In this wayEoInertials3
can be runned for retreiving the imu data both from legacy boards such asems
mtb3
ANDrfe
,mtb4
,strain2
.It requires: