-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
embObjIMU: extend the possibility to handle also mtb3 and ems gyro/acc #894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Nicogene
added a commit
to Nicogene/robots-configuration
that referenced
this pull request
Jul 12, 2023
It fixes robotology#420. It needs robotology/icub-main#894
valegagge
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pattacini
approved these changes
Jul 12, 2023
Nicogene
force-pushed
the
refactorEmbObjIMU
branch
from
July 19, 2023 14:35
ae34a68
to
8478238
Compare
Nicogene
force-pushed
the
refactorEmbObjIMU
branch
from
November 13, 2023 10:00
8478238
to
d4830fc
Compare
Nicogene
added a commit
to Nicogene/robots-configuration
that referenced
this pull request
Nov 13, 2023
It fixes robotology#420. It needs robotology/icub-main#894
Nicogene
force-pushed
the
refactorEmbObjIMU
branch
from
November 23, 2023 08:59
b7ad61c
to
512c019
Compare
Nicogene
added a commit
to Nicogene/robots-configuration
that referenced
this pull request
Nov 23, 2023
It fixes robotology#420. It needs robotology/icub-main#894
This has been tested both w/ "legacy" and "new" boards (alone and mixed) and it works: |
Nicogene
added a commit
to Nicogene/icub-main
that referenced
this pull request
Nov 27, 2023
This is possible since now covers also the functionalities (see robotology#894)
This was referenced Nov 27, 2023
Merged
Nicogene
added a commit
to Nicogene/icub-main
that referenced
this pull request
Nov 29, 2023
This is possible since now covers also the functionalities (see robotology#894)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the changes described here
With this change
embObjInertials
can be safely removed.TO BE TESTED