-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the friction parameters to support viscous and coulomb frictions #782
Conversation
src/libraries/icubmod/canBusMotionControl/CanBusMotionControl.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sgiraz
As a general remark, I've seen many modifications that are purely related to formatting. Could you please clean them up?
Hi @sgiraz We need to address also the compatibility with the required versions of |
|
Probably we need to keep @Nicogene in the loop as well given the upcoming distro release. |
Good point although we're not forced to include this dev into 2022.02.0. Therefore, any idea on the versioning to avoid conflicts and minimize the friction with the upcoming distro is more than welcome. |
If these changes require YARP 3.6.0 is fine to include them in the upcoming release, otherwise it would be tricky re-build the YARP packages in time |
Enable the eomcParser to accept the new friction parameters. In embObjMotionContro init add the new friction parameters to the joint configuration.
…uloumbUp/Down + Restore formatting with trailing spaces
CI started over after the merge of the following linked PR's: |
Now it have to be between 1.24.0 and 4
What's new in this PR:
viscousPos
,viscousNeg
,coulombPos
, andcoulombNeg
respectively.InembObjMotionControl.cpp
, theuser2raw
functions for the new parameters do not alter the values parsed from thexml
configuration file (this behavior can be easily changed).Minor clean up (some trailing spaces have been removed).vscode
folder to.gitignore
Note: