Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the friction parameters to support viscous and coulomb frictions #782

Merged
merged 6 commits into from
Mar 7, 2022

Conversation

sgiraz
Copy link
Contributor

@sgiraz sgiraz commented Feb 22, 2022

What's new in this PR:

  • eomcParser is now able to parse and manage the new friction parameters: viscousPos, viscousNeg, coulombPos, and coulombNeg respectively.
  • In embObjMotionControl.cpp, the user2raw functions for the new parameters do not alter the values parsed from the xml configuration file (this behavior can be easily changed).
  • Minor clean up (some trailing spaces have been removed)
  • add .vscode folder to .gitignore

Note:

  • CanBusMotionControl.cpp hasn't been updated to support the new friction parameters. if is necessary, we can do it.
  • The integration has been tested on a custom single joint setup (mc4plus + DC motor + aea2).

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sgiraz
As a general remark, I've seen many modifications that are purely related to formatting. Could you please clean them up?

@pattacini
Copy link
Member

pattacini commented Feb 23, 2022

Hi @sgiraz

We need to address also the compatibility with the required versions of yarp and icub-firmware-shared:

@sgiraz
Copy link
Contributor Author

sgiraz commented Feb 23, 2022

Hi @sgiraz

We need to address also the compatibility with the required versions of yarp and icub-firmware-shared:

We should probably check with @randaz81, because they could be updated during the official release

@pattacini
Copy link
Member

We should probably check with @randaz81, because they could be updated during the official release

icub-firmware-shared has been already updated so we can proceed. For YARP, we need to stick to the proper master release, the same.

@traversaro
Copy link
Member

traversaro commented Feb 23, 2022

We should probably check with @randaz81, because they could be updated during the official release

icub-firmware-shared has been already updated so we can proceed. For YARP, we need to stick to the proper master release, the same.

Probably we need to keep @Nicogene in the loop as well given the upcoming distro release.

@pattacini
Copy link
Member

Probably we need to keep @Nicogene in the loop as well given the upcoming distro release.

Good point although we're not forced to include this dev into 2022.02.0. Therefore, any idea on the versioning to avoid conflicts and minimize the friction with the upcoming distro is more than welcome.

@Nicogene
Copy link
Member

If these changes require YARP 3.6.0 is fine to include them in the upcoming release, otherwise it would be tricky re-build the YARP packages in time

@sgiraz sgiraz marked this pull request as ready for review February 25, 2022 18:08
@pattacini
Copy link
Member

Now it have to be between 1.24.0 and 4
@pattacini pattacini merged commit 420be39 into robotology:devel Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants