Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Path.notToBeReadable #942

Closed
9 tasks
robstoll opened this issue Jun 17, 2021 · 5 comments · Fixed by #989
Closed
9 tasks

add Path.notToBeReadable #942

robstoll opened this issue Jun 17, 2021 · 5 comments · Fixed by #989
Assignees
Milestone

Comments

@robstoll
Copy link
Owner

Platform (all, jvm, js): jvm
Extension (none, kotlin 1.3): none

Code related feature

expect(path).notToBeReadable()

//instead of

expect(path).feature { f(it::isReadable) }.toEqual(false)

Following the things you need to do:

logic

  • extend PathAssertions with a function isNotReadable (see PathAssertions as a guideline)
  • implement isNotReadable in DefaultPathAssertions.kt by using the ExpectImpl.feature.extractor...
  • run ./gradlew generateLogic which will update path.kt in logic

api-fluent

  • provide a function notToBeReadable which returns Expect<T> in pathExpectations.kt (see pathExpectations.kt toBeReadable as a guideline)
  • add @since 0.17.0 (adapt to current milestone) to KDOC
  • extend or write a separate Spec named PathExpectationsSpec in specs-common (see for instance PathExpectationsSpec) and extend it in atrium-api-fluent-en_GB-common/src/test

api-infix

  • provide a function notToBeReadable which returns Expect<T> in pathExpectations.kt (see pathExpectations.kt toBeReadable as a guideline)
  • add @since 0.17.0 (adapt to current milestone) to KDOC
  • extend or write a separate Spec named PathExpectationsSpec in specs-common (see for instance PathExpectationsSpec) and extend it in atrium-api-infix-en_GB-common/src/test

Your first contribution?

  • Write a comment I'll work on this if you would like to take this issue over.
    This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well.
  • See Your first code contribution for guidelines.
  • Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
    (Invite yourself in case you do not have an account yet).
@robstoll
Copy link
Owner Author

@dias-wagner something for you, write a comment and I'll assign the issue to you

@bhaumikankan
Copy link

i will work on this its my first time in open source

@bhaumikankan
Copy link

@robstoll can you guid me plz

@robstoll
Copy link
Owner Author

robstoll commented Sep 3, 2021

@bhaumikankan please take a look at your first contribution

Moreover, the steps you need to do are described in the description of this issue. Let me know if you have difficulties to tackle one of them.

@botex98
Copy link
Contributor

botex98 commented Oct 2, 2021

Hey, I've noticed that this ticket is not yet solved, and some time has passed since you assigned @bhaumikankan to this ticket, so I solved it. Please check it out.

@robstoll robstoll assigned botex98 and unassigned bhaumikankan Oct 2, 2021
@robstoll robstoll added this to the 0.17.0 milestone Oct 5, 2021
@robstoll robstoll linked a pull request Oct 5, 2021 that will close this issue
robstoll added a commit that referenced this issue Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants