-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#942 add Path.toNotBeReadable #989
Conversation
Codecov Report
@@ Coverage Diff @@
## main #989 +/- ##
==========================================
+ Coverage 90.83% 90.85% +0.02%
==========================================
Files 433 433
Lines 4374 4384 +10
Branches 221 221
==========================================
+ Hits 3973 3983 +10
Misses 352 352
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
...um-api-fluent-en_GB-jvm/src/main/kotlin/ch/tutteli/atrium/api/fluent/en_GB/pathAssertions.kt
Outdated
Show resolved
Hide resolved
...um-api-fluent-en_GB-jvm/src/main/kotlin/ch/tutteli/atrium/api/fluent/en_GB/pathAssertions.kt
Outdated
Show resolved
Hide resolved
...rium-api-infix-en_GB-jvm/src/main/kotlin/ch/tutteli/atrium/api/infix/en_GB/pathAssertions.kt
Outdated
Show resolved
Hide resolved
...-api-fluent-en_GB-jvm/src/main/kotlin/ch/tutteli/atrium/api/fluent/en_GB/pathExpectations.kt
Show resolved
Hide resolved
...rium-api-infix-en_GB-jvm/src/main/kotlin/ch/tutteli/atrium/api/infix/en_GB/pathAssertions.kt
Outdated
Show resolved
Hide resolved
logic/atrium-logic-jvm/src/main/kotlin/ch/tutteli/atrium/logic/impl/DefaultPathAssertions.kt
Outdated
Show resolved
Hide resolved
...atrium-specs-jvm/src/main/kotlin/ch/tutteli/atrium/specs/integration/PathExpectationsSpec.kt
Outdated
Show resolved
Hide resolved
...atrium-specs-jvm/src/main/kotlin/ch/tutteli/atrium/specs/integration/PathExpectationsSpec.kt
Outdated
Show resolved
Hide resolved
...-api-fluent-en_GB-jvm/src/main/kotlin/ch/tutteli/atrium/api/fluent/en_GB/pathExpectations.kt
Show resolved
Hide resolved
...rium-api-infix-en_GB-jvm/src/main/kotlin/ch/tutteli/atrium/api/infix/en_GB/pathAssertions.kt
Outdated
Show resolved
Hide resolved
@botex98 please rebase on main. |
@botex98 do you intend to finish this PR? Otherwise I am closing it and let someone else take over |
I had a very busy two weeks. But I intend on doing it. Give me a 72h window to do it. |
no problem at all, you can also take more time. just wanted to be sure, that it is not abandoned |
@robstoll please check again, I push a new commit to this PR. |
..._GB-jvm/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/PathExpectationSamples.kt
Outdated
Show resolved
Hide resolved
...lations-de_CH-jvm/src/main/kotlin/ch/tutteli/atrium/translations/DescriptionPathAssertion.kt
Outdated
Show resolved
Hide resolved
...lations-en_GB-jvm/src/main/kotlin/ch/tutteli/atrium/translations/DescriptionPathAssertion.kt
Outdated
Show resolved
Hide resolved
@botex98 thanks for the improvements, only a few details left and we are good to merge. |
logic/atrium-logic-jvm/src/main/kotlin/ch/tutteli/atrium/logic/impl/DefaultPathAssertions.kt
Outdated
Show resolved
Hide resolved
@robstoll Please check again. I resolved the threads myself (I didn't know if I should or not). Thanks for the review. |
@botex98 thanks for your first contribution to Atrium 👍 and don't forget to ⭐ Atrium if you liked it |
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.