Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#942 add Path.toNotBeReadable #989

Merged
merged 1 commit into from
Oct 23, 2021
Merged

#942 add Path.toNotBeReadable #989

merged 1 commit into from
Oct 23, 2021

Conversation

botex98
Copy link
Contributor

@botex98 botex98 commented Oct 2, 2021


I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

@botex98 botex98 requested a review from robstoll as a code owner October 2, 2021 15:45
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #989 (61c9b62) into main (4602f92) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
+ Coverage   90.83%   90.85%   +0.02%     
==========================================
  Files         433      433              
  Lines        4374     4384      +10     
  Branches      221      221              
==========================================
+ Hits         3973     3983      +10     
  Misses        352      352              
  Partials       49       49              
Flag Coverage Δ
bbc 79.72% <0.00%> (-0.19%) ⬇️
bc 79.58% <0.00%> (-0.19%) ⬇️
current 87.13% <100.00%> (+0.02%) ⬆️
current_windows 86.22% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...h/tutteli/atrium/api/infix/en_GB/pathAssertions.kt 100.00% <ø> (ø)
...n/kotlin/ch/tutteli/atrium/logic/PathAssertions.kt 0.00% <ø> (ø)
...utteli/atrium/api/fluent/en_GB/pathExpectations.kt 100.00% <100.00%> (ø)
...tutteli/atrium/api/infix/en_GB/pathExpectations.kt 100.00% <100.00%> (ø)
...c/generated/kotlin/ch/tutteli/atrium/logic/path.kt 100.00% <100.00%> (ø)
...tutteli/atrium/logic/impl/DefaultPathAssertions.kt 89.25% <100.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4602f92...61c9b62. Read the comment docs.

@robstoll robstoll linked an issue Oct 5, 2021 that may be closed by this pull request
9 tasks
@robstoll
Copy link
Owner

@botex98 please rebase on main. Path.notToBeWritable was added. Please check #1013, will surely help in fixing the remaining points in this PR (most have already been addressed by @rhushikesh, thanks)

@robstoll
Copy link
Owner

@botex98 do you intend to finish this PR? Otherwise I am closing it and let someone else take over

@botex98
Copy link
Contributor Author

botex98 commented Oct 21, 2021

I had a very busy two weeks. But I intend on doing it. Give me a 72h window to do it.

@robstoll
Copy link
Owner

no problem at all, you can also take more time. just wanted to be sure, that it is not abandoned

@botex98
Copy link
Contributor Author

botex98 commented Oct 23, 2021

@robstoll please check again, I push a new commit to this PR.

@robstoll
Copy link
Owner

@botex98 thanks for the improvements, only a few details left and we are good to merge.

@botex98
Copy link
Contributor Author

botex98 commented Oct 23, 2021

@robstoll Please check again. I resolved the threads myself (I didn't know if I should or not).

Thanks for the review.

@robstoll robstoll merged commit e0f0124 into robstoll:main Oct 23, 2021
@robstoll
Copy link
Owner

@botex98 thanks for your first contribution to Atrium 👍
We could use your help for other issues.

and don't forget to ⭐ Atrium if you liked it

@botex98 botex98 deleted the #942-add-Path-notToBeReadable branch October 23, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add Path.notToBeReadable
2 participants