Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce InAnyOrderOnlyReportingOptions #1119

Merged
merged 1 commit into from
Apr 9, 2022

Conversation

robstoll
Copy link
Owner

@robstoll robstoll commented Apr 7, 2022

On one hand for contains.inAnyOrder but on the other also for
contains.inOrder.only.grouped.inAnyOrder. There both should be
configurable, the grouped reporting as well as the in-group reporting
options

moreover:

  • deprecate InOrderOnlyReportingOptions.numberOfElementsInSummary,
    instead provide showOnlyFailingIfMoreExpectedElementsThan
  • only run js test tasks in CI (as they currently re-run even if they
    are successful)

I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

@robstoll robstoll linked an issue Apr 7, 2022 that may be closed by this pull request
On one hand for contains.inAnyOrder but on the other also for
contains.inOrder.only.grouped.inAnyOrder. There both should be
configurable, the grouped reporting as well as the in-group reporting
options

moreover:
- deprecate InOrderOnlyReportingOptions.numberOfElementsInSummary,
  instead provide showOnlyFailingIfMoreExpectedElementsThan
- only run js test tasks in CI (as they currently re-run even if they
  are successful)
@robstoll
Copy link
Owner Author

robstoll commented Apr 9, 2022

also add reportOptions to inAnyOrder.only not yet entirely done, there are some missing specs for mapLike.entriesOf

@robstoll robstoll merged commit 5683dad into main Apr 9, 2022
@robstoll robstoll deleted the #1094-report-options-inAny-Order branch April 9, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant