Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the crust from KSCrash #300

Merged
merged 5 commits into from
Jul 4, 2023
Merged

Conversation

matux
Copy link
Collaborator

@matux matux commented Jul 4, 2023

Description of the change

This is part of the work in integrating KSCrash source code directly into our library.

This is not merging into master but kscrash_integration.

This PR removes a lot of unused systems from KSCrash, greatly reducing the size footprint of our library as a whole and only leaving its crash detection core.

Removed:

This PR has been tested and found compiling and KSCrash core working as expected.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Jul 4, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #127332: Unable to integrate Apple SDK to Frameworks.

Copy link

@cyrusradfar cyrusradfar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good luck and god speed.

@matux matux merged commit 76855aa into kscrash_integration Jul 4, 2023
@matux matux deleted the leave_kscrash_core branch July 4, 2023 14:17
@matux matux mentioned this pull request Jul 11, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants