Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KSCrash source integration #303

Merged
merged 12 commits into from
Jul 14, 2023
Merged

KSCrash source integration #303

merged 12 commits into from
Jul 14, 2023

Conversation

matux
Copy link
Collaborator

@matux matux commented Jul 11, 2023

Description of the change

This is the aggregate of the KSCrash source integration. This PR is a collection of previously approved PRs.

These changes guarantee:

  • Integrating via cocoapods on Xcode 14.3 and higher.
  • Integrating the SDK to Frameworks and Libraries.

On top of that:
This change has reduced the final compiled for distribution size of the SDK by 25%.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Jul 11, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #127332: Unable to integrate Apple SDK to Frameworks.

@matux matux changed the title Kscrash integration KSCrash source integration Jul 11, 2023
@matux matux merged commit 44416fe into master Jul 14, 2023
@matux matux deleted the kscrash_integration branch July 14, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Critical Flaw: Compiler Error Due to Name Ambiguity in KSCrash when compiling the SDK
2 participants