Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed RollbarCrashReportTests to RollbarReportTests #314

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Conversation

matux
Copy link
Collaborator

@matux matux commented Jul 21, 2023

Description of the change

This PR renames RollbarCrashReportTests to RollbarReportTests to follow the new module schema post-KSCrash integration where RollbarCrashReport is now known as RollbarReport and our crash monitoring and recording module as RollbarCrash.

This PR also cleans up some unused testing xcschemes.


It seems the RollbarReport tests weren't being run by the CI, part of the cleanup of schemes included making RollbarReport part of the RollbarNotifier xcscheme and removing the separate RollbarCrashReport scheme. This seem to have inadvertently fix the issue and running these tests from the CI uncovered a minor issue in the way we were writing crash reports, where we were using the current time zone instead of GMT.

This has been fixed in this PR, too.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Jul 21, 2023
@matux matux requested review from ijsnow and mudetroit July 21, 2023 01:24
@matux matux merged commit a584368 into master Jul 21, 2023
@matux matux deleted the rename_test branch July 21, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants