Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed RollbarCrashReportTests to RollbarReportTests #314

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Renamed RollbarCrashReportTests to RollbarReportTests #314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6b397f
Renamed RollbarCrashReportTests to RollbarReportTests
matux Jul 21, 2023
609fbe1
Cleaned up test related xcschemes.
matux Jul 21, 2023
6b38258
Crash reports now always use GMT timezone
matux Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 0 additions & 52 deletions RollbarDeploys/.swiftpm/xcode/xcshareddata/xcschemes/RollbarDeploysTests-ObjC.xcscheme
View file
Open in desktop

This file was deleted.

52 changes: 0 additions & 52 deletions RollbarNotifier/.swiftpm/xcode/xcshareddata/xcschemes/RollbarCrashReportTests.xcscheme
View file
Open in desktop

This file was deleted.

46 changes: 16 additions & 30 deletions RollbarNotifier/.swiftpm/xcode/xcshareddata/xcschemes/RollbarNotifier.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,23 +14,9 @@
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "RollbarNotifier"
BuildableName = "RollbarNotifier"
BlueprintName = "RollbarNotifier"
ReferencedContainer = "container:">
</BuildableReference>
</BuildActionEntry>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "YES"
buildForProfiling = "YES"
buildForArchiving = "YES"
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "RollbarNotifier_RollbarCrashReportTests"
BuildableName = "RollbarNotifier_RollbarCrashReportTests"
BlueprintName = "RollbarNotifier_RollbarCrashReportTests"
BlueprintIdentifier = "RollbarCrash"
BuildableName = "RollbarCrash"
BlueprintName = "RollbarCrash"
ReferencedContainer = "container:">
</BuildableReference>
</BuildActionEntry>
Expand All @@ -42,23 +28,23 @@
buildForAnalyzing = "YES">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "RollbarCrash"
BuildableName = "RollbarCrash"
BlueprintName = "RollbarCrash"
BlueprintIdentifier = "RollbarNotifier"
BuildableName = "RollbarNotifier"
BlueprintName = "RollbarNotifier"
ReferencedContainer = "container:">
</BuildableReference>
</BuildActionEntry>
<BuildActionEntry
buildForTesting = "YES"
buildForRunning = "YES"
buildForProfiling = "YES"
buildForArchiving = "YES"
buildForAnalyzing = "YES">
buildForRunning = "NO"
buildForProfiling = "NO"
buildForArchiving = "NO"
buildForAnalyzing = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "RollbarCrashReport"
BuildableName = "RollbarCrashReport"
BlueprintName = "RollbarCrashReport"
BlueprintIdentifier = "RollbarReportTests"
BuildableName = "RollbarReportTests"
BlueprintName = "RollbarReportTests"
ReferencedContainer = "container:">
</BuildableReference>
</BuildActionEntry>
Expand Down Expand Up @@ -94,9 +80,9 @@
skipped = "NO">
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "RollbarCrashReportTests"
BuildableName = "RollbarCrashReportTests"
BlueprintName = "RollbarCrashReportTests"
BlueprintIdentifier = "RollbarReportTests"
BuildableName = "RollbarReportTests"
BlueprintName = "RollbarReportTests"
ReferencedContainer = "container:">
</BuildableReference>
</TestableReference>
Expand Down
52 changes: 0 additions & 52 deletions RollbarNotifier/.swiftpm/xcode/xcshareddata/xcschemes/RollbarNotifierTests-ObjC.xcscheme
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions RollbarNotifier/Sources/RollbarReport/Report/Timestamp.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ private final class ISO8601Formatter: DateFormatter {

self.locale = .init(identifier: "en_US_POSIX")
self.dateFormat = "yyyy-MM-dd HH:mm:ss.SSS ZZZ"
self.timeZone = .init(secondsFromGMT: 0)
}
}

Expand Down
3 changes: 2 additions & 1 deletion RollbarNotifier/Tests/LinuxMain.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import XCTest

import RollbarNotifierTests
import RollbarReportTests

XCTMain([
RollbarNotifierTests.allTests(),
RollbarCrashReportTests.allTests(),
RollbarReportTests.allTests(),
])
2 changes: 1 addition & 1 deletion RollbarNotifier/Tests/RollbarReportTests/Assets/report.crash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Version: 4 (1.0)
Code Type: ARM-64
Parent Process: ? [54621]

Date/Time: 2023-02-15 23:09:40.723 -0300
Date/Time: 2023-02-16 02:09:40.723 +0000
OS Version: iOS 16.2 (22D68)
Report Version: 104

Expand Down
8 changes: 4 additions & 4 deletions ...ReportTests/RollbarCrashReportTests.swift → ...llbarReportTests/RollbarReportTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
#if !os(watchOS)
import XCTest
@testable import RollbarCrashReport
@testable import RollbarReport

final class RollbarCrashReportTests: XCTestCase {
final class RollbarReportTests: XCTestCase {

func testRollbarCrashReportDiagnostics() {
func testRollbarReportDiagnostics() {
let report = Bundle.module
.url(forResource: "crash.json", withExtension: .none)
.flatMap { try? Data(contentsOf: $0) }
Expand All @@ -31,7 +31,7 @@ final class RollbarCrashReportTests: XCTestCase {
}
}

func testRollbarCrashReportFormatting() {
func testRollbarReportFormatting() {
let diagnosedCrash = Bundle.module
.url(forResource: "diagnosed.json", withExtension: .none)
.flatMap { try! Data(contentsOf: $0) }
Expand Down
2 changes: 1 addition & 1 deletion RollbarNotifier/Tests/RollbarReportTests/XCTestManifests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import XCTest
#if !canImport(ObjectiveC)
public func allTests() -> [XCTestCaseEntry] {
return [
testCase(RollbarCrashReportTests.allTests),
testCase(RollbarReportTests.allTests),
]
}
#endif
Expand Down