Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed breadcrumbs not being sorted correctly in obfuscated builds #112

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

matux
Copy link
Collaborator

@matux matux commented Aug 3, 2023

Description of the change

This PR solves an issue in the Dart SDK when dealing with obfuscated applications, where the Dart type system appears to deal with the # operator that creates a runtime Symbol identifier differently in obfuscated builds, that is, the type of the property is ignored.

The way this is fixed is by explicitly stating the type the property belongs to and creating a Symbol out of a String instead of using the type-safer # operator.

This PR also bumps the version and updates the changelog.

The main change is one line change.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Aug 3, 2023
@matux matux merged commit 1517290 into main Aug 3, 2023
2 checks passed
@matux matux deleted the obf_breadcrumb branch August 3, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants