Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed breadcrumbs not being sorted correctly in obfuscated builds #112

Merged
merged 2 commits into from
Aug 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rollbar_dart/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 1.3.1

- Fixed breadcrumbs not being processed in the right order in obfuscated builds.

## 1.3.0

- The log, debug, info, warn, error and critical methods in `Rollbar` now accept any type of object including `Error`, `Exception` and `String`. Dart objects that specialize `toString()` can be also passed and they'll be converted into their string representations.
Expand Down
2 changes: 1 addition & 1 deletion rollbar_dart/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ environment:

dependencies:
logging: ^1.0.2
rollbar_dart: ^1.1.0
rollbar_dart: ^1.3.0

dependency_overrides:
rollbar_common:
Expand Down
2 changes: 1 addition & 1 deletion rollbar_dart/lib/src/notifier/notifier.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import 'package:rollbar_dart/rollbar_dart.dart';
@sealed
abstract class Notifier {
// notifier version to be updated with each new release: [todo] automate
static const version = '1.3.0';
static const version = '1.3.1';
static const name = 'rollbar-dart';

FutureOr<Context> notify(Context state, final Event event);
Expand Down
2 changes: 1 addition & 1 deletion rollbar_dart/lib/src/telemetry.dart
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class Telemetry with Persistence<BreadcrumbRecord> implements Configurable {
);

List<Breadcrumb> breadcrumbs() => records
.sorted(by: #BreadcrumbRecord.timestamp)
.sorted(by: Symbol('${(BreadcrumbRecord).toString()}.timestamp'))
.map((record) => jsonDecode(record.breadcrumb) as JsonMap)
.map(Breadcrumb.fromMap)
.toList();
Expand Down
2 changes: 1 addition & 1 deletion rollbar_dart/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: rollbar_dart
description: Connect your Dart applications to Rollbar for error reporting.
version: 1.3.0
version: 1.3.1
homepage: https://www.rollbar.com
documentation: https://docs.rollbar.com/docs/flutter#dart
repository: https://github.com/rollbar/rollbar-flutter
Expand Down
Loading