Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal calls to deprecated methods #165

Closed
brianr opened this issue Nov 6, 2014 · 0 comments
Closed

Remove internal calls to deprecated methods #165

brianr opened this issue Nov 6, 2014 · 0 comments

Comments

@brianr
Copy link
Member

brianr commented Nov 6, 2014

There are still some internal calls to the deprecated methods Rollbar.report_exception and Rollbar.report_message:

lib/rollbar/better_errors.rb
18:        exception_data = Rollbar.report_exception(exception, request_data, person_data)

lib/rollbar/delayed_job.rb
13:            ::Rollbar.report_exception(e, data)

lib/rollbar/goalie.rb
13:        exception_data = Rollbar.report_exception(exception, request_data, person_data)

lib/rollbar/rake.rb
7:      Rollbar.report_exception(ex)

lib/rollbar/sidekiq.rb
14:          Rollbar.report_exception(e, :params => params)
31:      Rollbar.report_exception(e, :params => params)

spec/dummyapp/app/controllers/home_controller.rb
22:      Rollbar.report_exception(e)

spec/rollbar_spec.rb
1130:        Rollbar.report_exception(exception)
1153:            Rollbar.report_exception(exception)

lib/rollbar/rake_tasks.rb
22:    Rollbar.report_message("Test error from rollbar:test", "error")

spec/rollbar_spec.rb
912:      Rollbar.report_message("Test message")
921:      Rollbar.report_message("Test message that should be ignored")
930:      Rollbar.report_message("Test message with extra data", 'debug', :foo => "bar",

These should be changed to use Rollbar.error() instead. (The calls in spec/rollbar_bc_spec.rb should of course remain.)

brianr added a commit that referenced this issue Nov 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant