Remove deprecated method calls. Fix #165. #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,8 +10,9 @@ def call(worker, msg, queue) | |||
| yield | |||
| rescue Exception => e | |||
| params = msg.reject{ |k| PARAM_BLACKLIST.include?(k) } | |||
| scope = { :request => { :params => params } } | |||
There was a problem hiding this comment.
This is fine, though now that we have scope(), we could put this in a different part of the payload with a better name. Maybe custom? Will think about it more.
There was a problem hiding this comment.
We could, but actually report_exception is using :request for this case, perhaps the users will start viewing the data in a different format/way in their occurrence page.
There was a problem hiding this comment.
Right. Let's keep it as is for now - just making a note for myself.
|
Looks good, will merge once travis build completes. |
brianr
added a commit
that referenced
this pull request
Nov 7, 2014
Remove deprecated method calls. Fix #165.
|
Released in 1.2.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.