-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email errors in ActionMailer::DeliveryJob are not reported #487
Comments
@maxim yes, we will need to add our module to ActionMailer::DeliveryJob.class_eval do
include Rollbar::ActiveJob
end Thanks, |
@jondeandres just wondering why this was closed? It looks like this still needs to be manually included? |
@sandlerr you are right, reopening. Thanks! |
this can also written even shorter: ActionMailer::DeliveryJob.include Rollbar::ActiveJob |
Issue #487: Automatically add Rollbar::ActiveJob to ActionMailer::DeliveryJob
I see this was fixed a while ago (thanks!) but I suspect this is no longer working for Rails v6.0+ because of Rails switching from |
As pointed out by @grzuy in rollbar#487 (comment)
As pointed out by @grzuy in #487 (comment)
The docs recommend to add this to your ActiveJob jobs:
However, rails has a built-in job called
ActionMailer::DeliveryJob
which is used when you calldeliver_later
on your action mailer emails. Currently errors in that job are not being reported.I think it makes sense for this gem to automatically hook into that job as part of Rails integration.
The text was updated successfully, but these errors were encountered: