chore: code suggestions

rome · Dec 19, 2022 · 8177926 · 8177926
1 parent c96d1f6
commit 8177926
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 10 deletions.
diff --git a/...me_js_analyze/src/aria_analyzers/nursery/no_noninteractive_element_to_interactive_role.rs b/...me_js_analyze/src/aria_analyzers/nursery/no_noninteractive_element_to_interactive_role.rs
@@ -74,16 +74,22 @@ impl Rule for NoNoninteractiveElementToInteractiveRole {
                         AnyJsExpression::AnyJsLiteralExpression(
                             AnyJsLiteralExpression::JsStringLiteralExpression(string),
                         ) => string.inner_string_text().ok(),
-                        AnyJsExpression::JsTemplateExpression(template) => template
-                            .elements()
-                            .iter()
-                            .next()
-                            .and_then(|chunk| {
-                                chunk
-                                    .as_js_template_chunk_element()
-                                    .and_then(|t| t.template_chunk_token().ok())
-                            })
-                            .map(|t| t.token_text_trimmed()),
+                        AnyJsExpression::JsTemplateExpression(template) => {
+                            if template.elements().len() == 1 {
+                                template
+                                    .elements()
+                                    .iter()
+                                    .next()
+                                    .and_then(|chunk| {
+                                        chunk
+                                            .as_js_template_chunk_element()
+                                            .and_then(|t| t.template_chunk_token().ok())
+                                    })
+                                    .map(|t| t.token_text_trimmed())
+                            } else {
+                                None
+                            }
+                        }
                         _ => None,
                     }
                 }

diff --git a/...es/rome_js_analyze/tests/specs/nursery/noNoninteractiveElementToInteractiveRole/valid.jsx b/...es/rome_js_analyze/tests/specs/nursery/noNoninteractiveElementToInteractiveRole/valid.jsx
@@ -1 +1,2 @@
 let a = <span role="button"></span>;
+let a = <span role={`scroll${a}bar`}></span>;
diff --git a/...me_js_analyze/tests/specs/nursery/noNoninteractiveElementToInteractiveRole/valid.jsx.snap b/...me_js_analyze/tests/specs/nursery/noNoninteractiveElementToInteractiveRole/valid.jsx.snap
@@ -5,6 +5,7 @@ expression: valid.jsx
 # Input
 ```js
 let a = <span role="button"></span>;
+let a = <span role={`scroll${a}bar`}></span>;
 
 ```