fix(rome_json_formatter): JSON formatter does not respect lineWidth f…

…or arrays #4351 (#4367)

fix(rome_json_formatter): JSON formatter does not respect lineWidth for arrays #4351

CHANGELOG.md

@@ -13,6 +13,7 @@
 - import "module" assert {}
 + import "module" with {}
 ```
+- Fix an issue where JSON formatter does not respect `lineWidth` for arrays [#4351](https://github.com/rome/tools/issues/4351)
 ### Linter
 
 #### Other changes

crates/rome_cli/tests/snapshots/main_commands_format/does_not_format_ignored_directories.snap

@@ -8,8 +8,13 @@ expression: content
 {
   "formatter": {
     "ignore": [
-      "test1.js", "./test2.js", "./test3/**/*", "/test4/**/*", "test5/**/*",
-      "**/test6/*.js", "*.test7.js"
+      "test1.js",
+      "./test2.js",
+      "./test3/**/*",
+      "/test4/**/*",
+      "test5/**/*",
+      "**/test6/*.js",
+      "*.test7.js"
     ]
   }
 }

crates/rome_json_formatter/src/json/lists/array_element_list.rs

@@ -82,13 +82,6 @@ pub(crate) fn can_concisely_print_array_list(list: &JsonArrayElementList) -> boo
         return false;
     }
 
-    list.iter().all(|node| {
-        matches!(
-            node,
-            Ok(AnyJsonValue::JsonStringValue(_)
-                | AnyJsonValue::JsonBooleanValue(_)
-                | AnyJsonValue::JsonNullValue(_)
-                | AnyJsonValue::JsonNumberValue(_))
-        )
-    })
+    list.iter()
+        .all(|node| matches!(node, Ok(AnyJsonValue::JsonNumberValue(_))))
 }

crates/rome_json_formatter/tests/quick_test.rs

@@ -13,12 +13,19 @@ mod language {
 fn quick_test() {
     let src = r#"
 {
-    "a": 5,
-    "b": [1, 2, 3, 4],
-    "c": null,
-    "d": true,
-    "e": false
-}
+    "enabled": true,
+    "formatWithErrors": false,
+    "indentSize": 2,
+    "indentStyle": "space",
+    "lineWidth": 80,
+    "ignore": [
+      "**/cache/**",
+      "**/dist/**",
+      "./packages/laravel/**/*",
+      "./packages/presets/templates/**/*",
+      "./sandboxes/**/*"
+    ]
+  }
 "#;
     let parse = parse_json(src);
     let options = JsonFormatOptions::default();

crates/rome_json_formatter/tests/specs/json/array/fill_layout.json

@@ -0,0 +1,3 @@
+[
+	123231321, 123213213, 12312321, 12321123211232112321, 12321321, 1232132112321321123213211232132112321321
+]

crates/rome_json_formatter/tests/specs/json/array/fill_layout.json.snap

@@ -0,0 +1,34 @@
+---
+source: crates/rome_formatter_test/src/snapshot_builder.rs
+info: json/array/fill_layout.json
+---
+
+# Input
+
+```json
+[
+	123231321, 123213213, 12312321, 12321123211232112321, 12321321, 1232132112321321123213211232132112321321
+]
+
+```
+
+
+=============================
+
+# Outputs
+
+## Output 1
+
+-----
+Indent style: Tab
+Line width: 80
+-----
+
+```json
+[
+	123231321, 123213213, 12312321, 12321123211232112321, 12321321,
+	1232132112321321123213211232132112321321
+]
+```
+
+

crates/rome_json_formatter/tests/specs/json/array/layout.json.snap

@@ -35,9 +35,15 @@ Line width: 80
 ```json
 {
 	"fillLayout": [
-		"aaaa", "bbb", "cc",
+		"aaaa",
+		"bbb",
+		"cc",
 
-		true, false, 111, 44, null
+		true,
+		false,
+		111,
+		44,
+		null
 	],
 	"oneLineLayout": [
 		"aaa",

crates/rome_json_formatter/tests/specs/json/array/multi_line.json.snap

@@ -32,7 +32,9 @@ Line width: 80
 {
 	"array": [
 		"Longggggggggggggggggggggggggggggggggggg",
-		9999999999999999999999999999999999999, 1111112222222223333344444444, true
+		9999999999999999999999999999999999999,
+		1111112222222223333344444444,
+		true
 	],
 	"indented": [
 		"AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA",

crates/rome_json_formatter/tests/specs/json/array/nested.json.snap

@@ -36,8 +36,11 @@ Line width: 80
 	"long": [
 		11111,
 		[
-			"nestedddddddddddd", 22222222222222222222222222, true,
-			5555555555555555555555, "indenteddddddddddddddddddddddddddddd"
+			"nestedddddddddddd",
+			22222222222222222222222222,
+			true,
+			5555555555555555555555,
+			"indenteddddddddddddddddddddddddddddd"
 		],
 		"Element"
 	]

crates/rome_json_formatter/tests/specs/json/array/one_per_line_layout.json

@@ -0,0 +1,11 @@
+{
+	"boolean": [
+		true, true, true, true, true, true, true, true, false, false, false, true, false, false
+	],
+	"strings": [
+		"longlongstringlonglongstring", "12312321", "longlongstringlonglongstring"
+	],
+	"null": [
+		null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null
+	]
+}

crates/rome_json_formatter/tests/specs/json/array/one_per_line_layout.json.snap

@@ -0,0 +1,81 @@
+---
+source: crates/rome_formatter_test/src/snapshot_builder.rs
+info: json/array/one_per_line_layout.json
+---
+
+# Input
+
+```json
+{
+	"boolean": [
+		true, true, true, true, true, true, true, true, false, false, false, true, false, false
+	],
+	"strings": [
+		"longlongstringlonglongstring", "12312321", "longlongstringlonglongstring"
+	],
+	"null": [
+		null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null, null
+	]
+}
+
+```
+
+
+=============================
+
+# Outputs
+
+## Output 1
+
+-----
+Indent style: Tab
+Line width: 80
+-----
+
+```json
+{
+	"boolean": [
+		true,
+		true,
+		true,
+		true,
+		true,
+		true,
+		true,
+		true,
+		false,
+		false,
+		false,
+		true,
+		false,
+		false
+	],
+	"strings": [
+		"longlongstringlonglongstring",
+		"12312321",
+		"longlongstringlonglongstring"
+	],
+	"null": [
+		null,
+		null,
+		null,
+		null,
+		null,
+		null,
+		null,
+		null,
+		null,
+		null,
+		null,
+		null,
+		null,
+		null,
+		null,
+		null,
+		null,
+		null
+	]
+}
+```
+
+