Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_json_formatter): JSON formatter does not respect lineWidth for arrays #4351 #4367

Merged
merged 3 commits into from
Apr 11, 2023
Merged

fix(rome_json_formatter): JSON formatter does not respect lineWidth for arrays #4351 #4367

merged 3 commits into from
Apr 11, 2023

Conversation

denbezrukov
Copy link
Contributor

Summary

Fix #4351

Test Plan

cargo test

Changelog

  • The PR requires a changelog line

Documentation

  • The PR requires documentation
  • I will create a new PR to update the documentation

@netlify
Copy link

netlify bot commented Apr 11, 2023 •
edited
Loading

✅ Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 793b675
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/643574def8d92000080af6b4

@github-actions github-actions bot added the A-Formatter Area: formatter label Apr 11, 2023
@github-actions github-actions bot added the A-CLI Area: CLI label Apr 11, 2023
ematipico
ematipico approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a quick fix! 🐎

CHANGELOG.md Outdated Show resolved Hide resolved
@denbezrukov @ematipico
Update CHANGELOG.md
793b675 
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
@denbezrukov denbezrukov merged commit b839bdf into rome:main Apr 11, 2023
@jrson83
Copy link

jrson83 commented Apr 11, 2023

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
A-CLI Area: CLI A-Formatter Area: formatter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 JSON formatter does not respect lineWidth for arrays
3 participants
@denbezrukov @jrson83 @ematipico