Put closing curly on new line for empty blocks.

[MichaReiser]

Rome's formatter collapses empty block statements on a single line whereas Prettier enforces a line break before the closing } for the following statements.

• for..in
• for..of
• with
• switch
• switch case

Playground

Input

// Line break before closing `}`
if (true) {}
if (true) {} else {}

for (x in []) {}
for (x of []) {}

with({}) {}


switch ("test") {
}

switch ("test") {
  case "test": {}
}

test: {}

try {
} catch {
} finally {
}

// No Line breaks
class Test {}
interface X {}
type X = {};

function test() {}

for (;;) {}
while (true) {}
do {} while (true);

Prettier

// Line break before closing `}`
if (true) {
}
if (true) {
} else {
}

for (x in []) {
}
for (x of []) {
}

with ({}) {
}

switch ("test") {
}

switch ("test") {
	case "test": {
	}
}

test: {
}

try {
} catch {
} finally {
}

// No Line breaks
class Test {}
interface X {}
type X = {};

function test() {}

for (;;) {}
while (true) {}
do {} while (true);

Rome

// Line break before closing `}`
if (true) {
}
if (true) {
} else {
}

for (x in []) {}
for (x of []) {}

with({}) {}

switch ("test") {}

switch ("test") {
	case "test":
		{}
}

test: {}

try {} catch {} finally {}

// No Line breaks
class Test {}
interface X {}
type X = {};

function test() {}

for (;;) {}
while (true) {}
do {} while (true);

[ematipico]

I think here we should diverge and make everything look the same. If we liked prettier style (breaking before closing curly bracket), then we should apply the same behaviour to all the cases.

For example this:

// prettier
while (true) {}
with ({}) {
}

Why one case it breaks while the other it doesn't?

[MichaReiser]

My understanding is that it doesn't break for the more traditional loops like a for(;;) or the while loops because there are valid use cases where you don't need a body

while (iter.next() != null) {}
console.log(iter.current);

[ematipico]

Although do {} while () needs a body, I mean... I can't find a case where a do/while might have an empty body. In this case breaking might make sense? That's weird

[MichaReiser]

Although do {} while () needs a body, I mean... I can't find a case where a do/while might have an empty body. In this case breaking might make sense? That's weird

But then you probably want to keep while and do while consistent.