This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_formatter): Put closing curly on new line for empty blocks. #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!bench_formatter |
IWANABETHATGUY
commented
May 5, 2022
crates/rome_js_formatter/tests/specs/js/module/statement/empty_blocks.js
Show resolved
Hide resolved
|
The original input test case has been split into three parts, |
mrkldshv
reviewed
May 5, 2022
MichaReiser
approved these changes
May 6, 2022
|
@MichaReiser Fixed it. |
|
!bench_formatter |
|
Thanks @IWANABETHATGUY ! Nice work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #2406
Test Plan
The changed snapshot testing result should match prettier