Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

noPrototypeBuiltins, no-prototype-builtins #3979

Closed
Tracked by #3953
ematipico opened this issue Dec 6, 2022 · 2 comments · Fixed by #4101
Closed
Tracked by #3953

noPrototypeBuiltins, no-prototype-builtins #3979

ematipico opened this issue Dec 6, 2022 · 2 comments · Fixed by #4101
Assignees
@unvalley
Labels
I-Easy Implementation: easy task, usually a good fit for new contributors

Comments

@ematipico
Copy link
Contributor

ematipico commented Dec 6, 2022 •
edited
Loading

https://eslint.org/docs/latest/rules/no-prototype-builtins

Note: the documentation should promote hasOwn, instead of hasOwnProperty. hasOwn is supposed to be the native replacement
@ematipico ematipico mentioned this issue Dec 6, 2022
Open
30 tasks
@ematipico ematipico changed the title https://eslint.org/docs/latest/rules/no-prototype-builtins although instead of promoting hasOwnProperty, we should promote hasOwn, which is supposed to be the native replacement noPrototypeBuiltins, no-prototype-builtins Dec 6, 2022
@ematipico ematipico added the I-Easy Implementation: easy task, usually a good fit for new contributors label Dec 6, 2022
@unvalley
Copy link
Contributor

I'll work on this.

@xunilrj xunilrj assigned xunilrj and unvalley and unassigned xunilrj Dec 18, 2022
@unvalley unvalley mentioned this issue Dec 23, 2022
Merged
1 task
@github-actions
Copy link

github-actions bot commented Jan 2, 2023

👋 @rome/staff please triage this issue by adding one of the following labels: S-Bug: confirmed, S-Planned , S-Wishlist or umbrella

ematipico pushed a commit that referenced this issue Jan 9, 2023
@unvalley
feat(rome_js_analyze): noPrototypeBuiltins (#4101)
e0325d3 
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Closes #3979
nhedger pushed a commit to biomejs/biome-vscode that referenced this issue Sep 21, 2023
@unvalley
feat(rome_js_analyze): noPrototypeBuiltins (#4101)
1ab9137 
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Closes rome/tools#3979
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@unvalley unvalley

Labels
I-Easy Implementation: easy task, usually a good fit for new contributors
Projects
ESlint recommended rules
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rome_js_analyze): noPrototypeBuiltins
3 participants
@xunilrj @ematipico @unvalley