This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): noPrototypeBuiltins
#4101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
unvalley
commented
Dec 23, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_prototype_builtins.rs
Outdated
Show resolved
Hide resolved
unvalley
commented
Dec 23, 2022
| foo?.hasOwnProperty(bar); | ||
| (foo?.hasOwnProperty)("bar"); | ||
| foo?.["hasOwnProperty"]("bar"); | ||
| (foo?.[`hasOwnProperty`])("bar"); |
There was a problem hiding this comment.
I created test cases based on ESLint test cases.
I didn't add a test for:
String.raw`foo.bar["propertyIsEnumerable"]('baz')`Honestly, I couldn't find out how to recreate JsCallExpression from the token foo.bar["propertyIsEnumerable"]('baz'). If I should handle the case, please tell me the way...
There was a problem hiding this comment.
I think we can skip it for now, if you think it requires another PR to add this case.
unvalley
commented
Dec 23, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_prototype_builtins.rs
Outdated
Show resolved
Hide resolved
unvalley
requested review from
leops,
ematipico,
xunilrj and
a team
as code owners
ematipico
reviewed
Dec 29, 2022
crates/rome_js_analyze/src/analyzers/nursery/no_prototype_builtins.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_prototype_builtins.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_prototype_builtins.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_prototype_builtins.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_prototype_builtins.rs
Outdated
Show resolved
Hide resolved
| foo?.hasOwnProperty(bar); | ||
| (foo?.hasOwnProperty)("bar"); | ||
| foo?.["hasOwnProperty"]("bar"); | ||
| (foo?.[`hasOwnProperty`])("bar"); |
There was a problem hiding this comment.
I think we can skip it for now, if you think it requires another PR to add this case.
crates/rome_js_analyze/src/analyzers/nursery/no_prototype_builtins.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_prototype_builtins.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/nursery/no_prototype_builtins.rs
Outdated
Show resolved
Hide resolved
|
@ematipico Thanks for reviewing, I updated the PR. |
chore: just codegen test: update snapshot and docs chore: cargo fmt chore: just codegen chore: fix indent test: update note for hasOwn chore: just codegen docs: update for note about hasOwn Update crates/rome_js_analyze/src/analyzers/nursery/no_prototype_builtins.rs Co-authored-by: Emanuele Stoppa <my.burning@gmail.com> Update crates/rome_js_analyze/src/analyzers/nursery/no_prototype_builtins.rs Co-authored-by: Emanuele Stoppa <my.burning@gmail.com> Update crates/rome_js_analyze/src/analyzers/nursery/no_prototype_builtins.rs Co-authored-by: Emanuele Stoppa <my.burning@gmail.com> Update crates/rome_js_analyze/src/analyzers/nursery/no_prototype_builtins.rs Co-authored-by: Emanuele Stoppa <my.burning@gmail.com> Update crates/rome_js_analyze/src/analyzers/nursery/no_prototype_builtins.rs Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
test: update snapshot chore: just codegen
chore: cargo fmt
ematipico
approved these changes
Jan 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3979
Summary
Implement a rule
noPrototypeBuiltins.hasOwn()instead ofhasOwnProperty()Test Plan
cargo test -p rome_js_analyze -- no_prototype_builtinsDocumentation
[ ] I will create a new PR to update the documentationjust codegen