fix(rome_js_analyzer): fix false positive #3261

[ematipico]

Summary

This PR fixes #3261

The fix is simple. It iterates over all the all_reads of the binding and checks if at least one is used as a JsxRefereceIdentifier.

Test Plan

Added a new test case

[netlify]

✅ Deploy Preview for rometools canceled.

Name	Link
🔨 Latest commit	34e6111
🔍 Latest deploy log	https://app.netlify.com/sites/rometools/deploys/632d5c973696550008b3f72c

[github-actions]

Playground for commit c9158bf

[MichaReiser]

Would you mind adding a more descriptive title. It avoids that I have to open the issue when e.g. going through the commits using git.

[MichaReiser]

!bench_analyzer

[github-actions]

Analyzer Benchmark Results

group                     main                                   pr
-----                     ----                                   --
analyzer/css.js           1.00      2.0±0.03ms     5.8 MB/sec    1.01      2.0±0.02ms     5.7 MB/sec
analyzer/index.js         1.00      5.8±0.01ms     5.6 MB/sec    1.01      5.8±0.03ms     5.6 MB/sec
analyzer/lint.ts          1.00      2.8±0.05ms    14.8 MB/sec    1.01      2.8±0.02ms    14.6 MB/sec
analyzer/parser.ts        1.00      6.9±0.05ms     7.1 MB/sec    1.02      7.0±0.06ms     7.0 MB/sec
analyzer/router.ts        1.00      4.9±0.03ms    12.5 MB/sec    1.01      5.0±0.05ms    12.3 MB/sec
analyzer/statement.ts     1.00      6.8±0.07ms     5.2 MB/sec    1.01      6.9±0.07ms     5.1 MB/sec
analyzer/typescript.ts    1.00     10.5±0.04ms     5.2 MB/sec    1.02     10.7±0.04ms     5.1 MB/sec

[ematipico]

!bench_analyzer

[github-actions]

Analyzer Benchmark Results

group                     main                                   pr
-----                     ----                                   --
analyzer/css.js           1.00      2.6±0.07ms     4.5 MB/sec    1.03      2.6±0.13ms     4.4 MB/sec
analyzer/index.js         1.00      7.5±0.41ms     4.3 MB/sec    1.01      7.5±0.34ms     4.3 MB/sec
analyzer/lint.ts          1.00      3.5±0.12ms    11.8 MB/sec    1.12      4.0±0.16ms    10.5 MB/sec
analyzer/parser.ts        1.00      8.6±0.35ms     5.7 MB/sec    1.01      8.6±0.29ms     5.6 MB/sec
analyzer/router.ts        1.00      6.1±0.19ms    10.1 MB/sec    1.03      6.2±0.25ms     9.9 MB/sec
analyzer/statement.ts     1.00      8.7±0.32ms     4.1 MB/sec    1.01      8.7±0.35ms     4.1 MB/sec
analyzer/typescript.ts    1.02     13.8±0.65ms     4.0 MB/sec    1.00     13.5±0.67ms     4.0 MB/sec

[ematipico]

!bench_analyzer

[github-actions]

Analyzer Benchmark Results

group                     main                                   pr
-----                     ----                                   --
analyzer/css.js           1.00  1954.1±87.00µs     5.9 MB/sec    1.05      2.1±0.12ms     5.6 MB/sec
analyzer/index.js         1.00      5.5±0.24ms     5.9 MB/sec    1.05      5.8±0.28ms     5.6 MB/sec
analyzer/lint.ts          1.00      2.8±0.14ms    15.0 MB/sec    1.00      2.8±0.15ms    15.0 MB/sec
analyzer/parser.ts        1.00      6.8±0.46ms     7.2 MB/sec    1.00      6.7±0.31ms     7.2 MB/sec
analyzer/router.ts        1.00      4.7±0.20ms    13.0 MB/sec    1.00      4.7±0.26ms    13.0 MB/sec
analyzer/statement.ts     1.00      6.5±0.30ms     5.5 MB/sec    1.01      6.5±0.37ms     5.4 MB/sec
analyzer/typescript.ts    1.00     10.6±0.68ms     5.1 MB/sec    1.00     10.7±0.65ms     5.1 MB/sec