fix(npm/js_api): Ensure JS API build contains dist folder
#3648
Conversation
✅ Deploy Preview for docs-rometools ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
MichaReiser
force-pushed
the
fix/js-api-build
branch
from
8ad95ac
to
5e1c47e
Compare
MichaReiser
changed the title
| "rome": "^0.10.1-next", | ||
| "@rometools/wasm-nodejs": "^0.10.1-next", | ||
| "@rometools/backend-jsonrpc": "^0.10.1-next" | ||
| "rome": "^10.0.0", |
There was a problem hiding this comment.
We should probably automate this
| @@ -1 +0,0 @@ | |||
| dist/ | |||
There was a problem hiding this comment.
Already covered by the root gitignore
|
Comparing fix(npm/js_api): Ensure JS API build contains dist files Snapshot #1 to median since last deploy of rome.tools.
1 page tested
|
| Chrome Desktop | iPhone, 4G LTE | Motorola Moto G Power, 3G connection |
|---|---|---|
 |
 |
 |
Most significant changes
 |
Value | Budget |
|---|---|---|
| Cumulative Layout Shift iPhone, 4G LTE |
0.082  from 0.009 |
 |
| Cumulative Layout Shift Chrome Desktop |
0.044  from 0.005 |
|
| JS Parse & Compile iPhone, 4G LTE |
80ms  from 10ms |
|
| Total JavaScript Size in Bytes Chrome Desktop |
1.55 MB  from 309 KB |
|
| Total JavaScript Size in Bytes iPhone, 4G LTE |
1.55 MB from 309 KB |
|
13 other significant changes: Total JavaScript Size in Bytes on Motorola Moto G Power, 3G connection, Number of Requests on Chrome Desktop, Number of Requests on iPhone, 4G LTE, Number of Requests on Motorola Moto G Power, 3G connection, Total Page Size in Bytes on Chrome Desktop, Total Page Size in Bytes on iPhone, 4G LTE, Total Page Size in Bytes on Motorola Moto G Power, 3G connection, Total Image Size in Bytes on Chrome Desktop, Total Image Size in Bytes on iPhone, 4G LTE, Total Image Size in Bytes on Motorola Moto G Power, 3G connection, Total HTML Size in Bytes on Chrome Desktop, Total HTML Size in Bytes on iPhone, 4G LTE, Total HTML Size in Bytes on Motorola Moto G Power, 3G connection
Calibre: Site dashboard | View this PR | Edit settings | View documentation
MichaReiser
changed the title
dist folder
* upstream/main: fix(npm/js-api): Import type from @rometools/backend-jsonrpc (rome#3647) doc(npm/js-api): Add experimental warning to README fix(npm/js-api): Lazy load backend implementations (rome#3652) feat(rome_lsp): stop the daemon after the last client disconnects (rome#3643) fix(npm/js_api): Ensure JS API build contains `dist` folder (rome#3648) fix(rome_cli): ensures the service only connects to compatible versions (rome#3642) feat(playground): add settings button and group IR (rome#3559) release: v10.0.1 (rome#3649) fix(rome_js_analyze): False positives for interactive elements in `useKeyWithClickEvents` (rome#3644) fix(rome_js_semantic): support for object and array bindings when exporting (rome#3620) doc(editors): Clarify Rome discovery (rome#3639) fix(rome_js_analyze): improve the detection of `ReactDOM.render` calls in `noRenderReturnValue` (rome#3626) chore(npm): add license (rome#3629) Add rustdocs index Add environment Change rust docs to use Netlify fix(rome_js_analyze): useValidAnchor considering all possible expressions (rome#3599) fix(rome_js_formatter): Trailing comma inside import rome#3600 (rome#3624)
Summary
The build extracted the
distartifacts in thenpmdirectory instead ofnpm/js-api/dist.Fixes #3646
Test Plan
I added test logging to the build and triggered a manual build.
You can now see that the
distfolder is present in thenpm/js-api/distfolder before runningnpm publish