Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(npm/js_api): Ensure JS API build contains dist folder #3648

Merged
merged 6 commits into from
Nov 10, 2022
Merged

fix(npm/js_api): Ensure JS API build contains dist folder #3648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5e1c47e
fix(npm/js_api): Build workflow
MichaReiser Nov 10, 2022
9408677
Temporarily remove branch protection
MichaReiser Nov 10, 2022
d935a9c
Fix dependencies
MichaReiser Nov 10, 2022
a4dc0ba
Fix extraction path
MichaReiser Nov 10, 2022
7656aef
Merge branch 'main' into fix/js-api-build
MichaReiser Nov 10, 2022
59a4ca9
Undo testing changes & pump version
MichaReiser Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release_js_api.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ jobs:
working-directory: npm/js-api
run: |
pnpm i
pnpm build
pnpm build

- name: Upload JS API artifact
uses: actions/upload-artifact@v3
Expand All @@ -126,7 +126,7 @@ jobs:
uses: actions/download-artifact@v3
with:
name: js-api
path: npm
path: npm/js-api/dist

- name: Install Node.js
uses: actions/setup-node@v3
Expand Down
1 change: 0 additions & 1 deletion npm/js-api/.gitignore
View file
Open in desktop

This file was deleted.

10 changes: 5 additions & 5 deletions npm/js-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@rometools/js-api",
"version": "0.1.1",
"version": "0.1.2",
"description": "JavaScript APIs for the Rome package",
"scripts": {
"tsc": "tsc --noEmit",
Expand Down Expand Up @@ -40,9 +40,9 @@
"rome": "../rome"
},
"peerDependencies": {
"rome": "^0.10.1-next",
"@rometools/wasm-nodejs": "^0.10.1-next",
"@rometools/backend-jsonrpc": "^0.10.1-next"
"rome": "^10.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably automate this

"@rometools/wasm-nodejs": "^10.0.0",
"@rometools/backend-jsonrpc": "^10.0.0"
},
"peerDependenciesMeta": {
"rome": {
Expand All @@ -55,4 +55,4 @@
"optional": true
}
}
}
}